From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751444AbcGNINi (ORCPT ); Thu, 14 Jul 2016 04:13:38 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:53213 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751113AbcGNINU (ORCPT ); Thu, 14 Jul 2016 04:13:20 -0400 From: Arnd Bergmann To: Jiri Pirko Cc: Jiri Pirko , netdev@vger.kernel.org, Steven Rostedt , Ingo Molnar , "David S . Miller" , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] devlink: fix build error for CONFIG_MODULES=n Date: Thu, 14 Jul 2016 10:12:43 +0200 Message-ID: <4442123.LuHpPd1R94@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160714062111.GA2228@nanopsycho.orion> References: <20160713210338.1647521-1-arnd@arndb.de> <20160714062111.GA2228@nanopsycho.orion> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:bVc+V+3E+EHD4T/qBfLZP9keD00C38Bj787uZkJPNKY8m4gsly6 v5MrEX0sb3Y4xl8CxtSccaNrf/B6Zraotb2jwQIBuevBSOCaNQ3UnF6zUwmjFKtsJBhMDT0 OtrFYwRXlvAotqw4klOBNyFLPdJlZW7pLJ3NbqXghI+AqCx7DYesdl6wH0u6c/OnZ85UHGi mn+5kbDnBnOdfuXwzpI7w== X-UI-Out-Filterresults: notjunk:1;V01:K0:dCxbHoCmo5I=:l6j2ez+N1VPHbex8zxpNNB qoZ1wKn6YqbHKd2h2IfeBJEeSHRQg0EdHAfSmeE3Du5y3vh/Qg2iu7xe1iLORV/Mprp5NXnK+ fL00L1PkqJ2UU5WTskN4ig4iKXzTe1vOTkNu7uVk27vh8HncV1qEbVk66AjtixdDaO+F1NQN7 Nkc9iY10UnEkAw3Pvo99KGgGQwVCU+HNXX4gQFCF7rG3NSdmUuRn07GK3B5rfG8i4T5uBMStS wuGkSbgzssLFtzcisNMOWtO+sEiZrV5t3+8nSpaUwUHEubpJMn6kLHHTAVKg7KI9L44xu/A73 ubn3GIKJbjctwxb09PnuKbPMhrFLDq93r0QZhEe8/v/CkRk7BIbJrdCXWLuLmrbQZE/NjHcnj SebUN3Nnh7nD5tRK1XW7U1O3FAJErhUfaK89jNEPT2NJam1YMggk5gedWTAGt+Lx9N8EAugVB bsMfOiNQLXFurvtL5izsciCnwZ75I9nqWq6ciGdSpL4agSuXVZbVvTjTK1Apkyf/dFMTpttGC 6TJFPZlGO4mZQLPpBlOCqLEsIEfK0/8dU/UbOeBRszzkIJ45qxwOwkZFKHSvqobH2bVQEXIqZ s+vRTpT60VG/dsoNn05s7SoolSfMf4acw2talfLyP9zVwTPV+btX6CEfu3DVmWeIF+7rdRq2U PUSThM+3rLaPHBtAbm9hxgepKbcbGVOMTq0MDBv1FFI2emYUfZZV1ENnkDpCEIY2JDE0VkVUb Rox1IOIPJ9HoK5jD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, July 14, 2016 8:21:11 AM CEST Jiri Pirko wrote: > >diff --git a/include/trace/events/devlink.h b/include/trace/events/devlink.h > >index 333c32ac9bfa..26f92d3c7e9c 100644 > >--- a/include/trace/events/devlink.h > >+++ b/include/trace/events/devlink.h > >@@ -22,7 +22,11 @@ TRACE_EVENT(devlink_hwmsg, > > TP_STRUCT__entry( > > __string(bus_name, devlink->dev->bus->name) > > __string(dev_name, dev_name(devlink->dev)) > >+#ifdef CONFIG_MODULES > > __string(owner_name, devlink->dev->driver->owner->name) > > I think would be better to use driver->name. I looks like it is always > present. I will do some tests and send a patch. > Yes, good idea. Arnd