From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933387AbcKOUy5 (ORCPT ); Tue, 15 Nov 2016 15:54:57 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34797 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932196AbcKOUyy (ORCPT ); Tue, 15 Nov 2016 15:54:54 -0500 Subject: Re: [net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver To: Lino Sanfilippo , Andrew Lunn References: <1479012453-19410-1-git-send-email-LinoSanfilippo@gmx.de> <1479012453-19410-2-git-send-email-LinoSanfilippo@gmx.de> <20161113195544.GA18258@lunn.ch> <69558f55-824a-7063-d9b3-ccc0a6113b87@gmx.de> Cc: davem@davemloft.net, charrer@alacritech.com, liodot@gmail.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org From: Florian Fainelli Message-ID: <4450caf4-e1cf-5187-1337-c46b81b08708@gmail.com> Date: Tue, 15 Nov 2016 12:54:51 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <69558f55-824a-7063-d9b3-ccc0a6113b87@gmx.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/2016 12:46 PM, Lino Sanfilippo wrote: >> Could this be pulled out into a standard PHY driver? All the SLIC >> SLIC_PCR_ defines seems to be the same as those in mii.h. This could >> be a standard PHY hidden behind a single register. >> >> Andrew > > You are right, the driver should really use the defines in mii.h. I will fix this in > a v2. > > Concerning the use of the PHY API: What would be the advantage of using it? Note that the > phy is always internal and not interchangeable. Is not the interchangeability of PHYs > the main reason for using this API? Not reinventing the wheel primarily, while PHYLIB also solves the plug & play aspect of external PHYs, it also solves the basic link management, and consistent and reasonably well defined interface to user-space and drivers (statistics reporting, link, auto-negotiation, EEE etc.). -- Florian