From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4433C433F5 for ; Thu, 10 Mar 2022 14:55:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245426AbiCJO4c convert rfc822-to-8bit (ORCPT ); Thu, 10 Mar 2022 09:56:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347939AbiCJOvf (ORCPT ); Thu, 10 Mar 2022 09:51:35 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F19C819C35; Thu, 10 Mar 2022 06:50:32 -0800 (PST) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSK7V-0004bE-W9; Thu, 10 Mar 2022 15:50:26 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Colin Ian King , Nick Desaulniers Cc: Sandy Huang , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, knaerzche@gmail.com Subject: Re: [PATCH] drm/rockchip: remove redundant assignment to pointer connector Date: Thu, 10 Mar 2022 15:50:25 +0100 Message-ID: <4453075.DPozGzHrQt@diego> In-Reply-To: References: <20220307181704.149076-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, looks like I wasn't in the original recipient list, so only got Nick's answer. Am Mittwoch, 9. März 2022, 00:10:31 CET schrieb Nick Desaulniers: > On Mon, Mar 7, 2022 at 10:17 AM Colin Ian King wrote: > > > > The pointer connector is being assigned a value that is never read, > > it is being re-assigned in the following statement. The assignment > > is redundant and can be removed. > > > > Cleans up clang scan build warning: > > drivers/gpu/drm/rockchip/rockchip_rgb.c:153:2: warning: Value stored > > to 'connector' is never read [deadcode.DeadStores] > > + Author & reviewer of: > Fixes: 2e87bf389e13 ("drm/rockchip: add DRM_BRIDGE_ATTACH_NO_CONNECTOR > flag to drm_bridge_attach") > > > > > Signed-off-by: Colin Ian King > > --- > > drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c > > index 2494b079489d..92a727931a49 100644 > > --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c > > +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c > > @@ -150,7 +150,6 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev, > > if (ret) > > goto err_free_encoder; > > > > - connector = &rgb->connector; > > connector = drm_bridge_connector_init(rgb->drm_dev, encoder); I don't think this will work as expected. Yes, the whole thing looks a bit broken right now, but the connector field in the rockchip_rgb struct still exists and rockchip_rgb_fini also still uses it when calling drm_connector_cleanup. Same issue seems to exist in in rockchip_lvds.c with drm_connector_cleanup it seems. I guess drm_bridge_connector_destroy() is responsible for the cleanup so the drm_connector_cleanup call both in rockchip_rgb and rockchip_lvds as well as the local connector elements can go away as well? Heiko > > if (IS_ERR(connector)) { > > DRM_DEV_ERROR(drm_dev->dev, > > -- > > 2.35.1 > > > > > > >