From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Peter Xu <peterx@redhat.com>, linux-kernel@vger.kernel.org
Cc: Andrea Arcangeli <aarcange@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Mark Hairgrove <mhairgrove@nvidia.com>,
peterx@redhat.com, Jerome Glisse <jglisse@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Alistair Popple <alistair@popple.id.au>,
linuxppc-dev@lists.ozlabs.org, Jason Wang <jasowang@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: powerpc/powernv/npu: Remove redundant change_pte() hook
Date: Fri, 22 Feb 2019 20:47:46 +1100 (AEDT) [thread overview]
Message-ID: <445RN24dKKz9sB3@ozlabs.org> (raw)
In-Reply-To: <20190131103022.10218-1-peterx@redhat.com>
On Thu, 2019-01-31 at 10:30:22 UTC, Peter Xu wrote:
> The change_pte() notifier was designed to use as a quick path to
> update secondary MMU PTEs on write permission changes or PFN changes.
> For KVM, it could reduce the vm-exits when vcpu faults on the pages
> that was touched up by KSM. It's not used to do cache invalidations,
> for example, if we see the notifier will be called before the real PTE
> update after all (please see set_pte_at_notify that set_pte_at was
> called later).
>
> All the necessary cache invalidation should all be done in
> invalidate_range() already.
>
> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> CC: Paul Mackerras <paulus@samba.org>
> CC: Michael Ellerman <mpe@ellerman.id.au>
> CC: Alistair Popple <alistair@popple.id.au>
> CC: Alexey Kardashevskiy <aik@ozlabs.ru>
> CC: Mark Hairgrove <mhairgrove@nvidia.com>
> CC: Balbir Singh <bsingharora@gmail.com>
> CC: David Gibson <david@gibson.dropbear.id.au>
> CC: Andrea Arcangeli <aarcange@redhat.com>
> CC: Jerome Glisse <jglisse@redhat.com>
> CC: Jason Wang <jasowang@redhat.com>
> CC: linuxppc-dev@lists.ozlabs.org
> CC: linux-kernel@vger.kernel.org
> Signed-off-by: Peter Xu <peterx@redhat.com>
> Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
> Reviewed-by: Alistair Popple <alistair@popple.id.au>
> Reviewed-by: Balbir Singh <bsingharora@gmail.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/1b58a975be36994a572ae3b3fb3e0232
cheers
prev parent reply other threads:[~2019-02-22 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 10:30 [PATCH] powerpc/powernv/npu: Remove redundant change_pte() hook Peter Xu
2019-01-31 17:11 ` Andrea Arcangeli
2019-02-05 3:52 ` Alistair Popple
2019-02-06 2:55 ` Balbir Singh
2019-02-22 9:47 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445RN24dKKz9sB3@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aarcange@redhat.com \
--cc=aik@ozlabs.ru \
--cc=alistair@popple.id.au \
--cc=david@gibson.dropbear.id.au \
--cc=jasowang@redhat.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhairgrove@nvidia.com \
--cc=paulus@samba.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).