From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47903C49EA5 for ; Thu, 24 Jun 2021 02:10:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30DA3613A9 for ; Thu, 24 Jun 2021 02:10:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229938AbhFXCNN (ORCPT ); Wed, 23 Jun 2021 22:13:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229844AbhFXCNL (ORCPT ); Wed, 23 Jun 2021 22:13:11 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9177FC061574 for ; Wed, 23 Jun 2021 19:10:52 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id t19-20020a17090ae513b029016f66a73701so4925886pjy.3 for ; Wed, 23 Jun 2021 19:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k4QIFhqycNj8GLoDIog1T+fSxwI5JTO5+UemhkS0t2o=; b=R7ELIICz9WdFf+PGQ2jd2Jt56KpGpgdj/4QUrfnuSVt9qDOiSeZ1+sg7CIfqUbvAiT BWH1QCojYmnncpNYSViPShe1SstM37ttCtOYpejVyNdYGeE/u1yGV+8VOSPgf+uC0bkB 56aZ4Z1rFm/m9lLLqvEaf/z8jJvjdqJUhL7DHA4Oo2PmCaC0y/18re6FfDRRT0Dl749x kRvLjp0Wveo0QxlOCCPcu5iOPOSwAKriMPrSTTm+NGvs9+Z5GURRdgR2KAFAcpCe3EhQ 4WIyQOLG2uLbH8iZwSgi2PUmd9pXfEGiA86tGVEBAQzjf4U4l8xdcQPwXswrG2ALuma4 lVcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k4QIFhqycNj8GLoDIog1T+fSxwI5JTO5+UemhkS0t2o=; b=US9tvmlcuA7D4Ks24yVHoF03uHW3k0QgfNcB4toqJ3Zb7oIktb1whT5cm6BJfnYJ7i x1aFYE53fLcmCWz5CEAZtYj6UqRR99R3QIPKhCR/Dr0Wy9gOSDMGIRCJxD2RcEWDsRLM MkC/cK5C4gysekxTlwNB91rv9CoFGY3ChS37XTM84XqqlAPYld1OSsiGMJbVDvMjRO1r WkUHEnA6xo1uoZnqYybyX5z222Ts3o72brhpj2Uw+ZfMuhcigBPebl8+Zb3sbgdVp/RV raGGceiJSQ9EB60LVvetFKK3uOgOfa3cKobo98SAlmaRxnLZ8s5NLegat6FRrjzLE5iR MFBg== X-Gm-Message-State: AOAM533PzY8kbgdLk2V6+aC9wEkyH34ArzxYsQv7u6BV05eQeDvVkPqE i2Tq2msrFeMumQfpJfLhhMcCbA== X-Google-Smtp-Source: ABdhPJyA+BlUi6sU0IPP4K9bydQuXz1y1ea9apcmprLEGbvqRPkSS7TMCoR2Ioy9JSEx0GmseMDG9w== X-Received: by 2002:a17:90b:11ca:: with SMTP id gv10mr12509991pjb.94.1624500652154; Wed, 23 Jun 2021 19:10:52 -0700 (PDT) Received: from localhost ([136.185.134.182]) by smtp.gmail.com with ESMTPSA id r207sm988256pfc.118.2021.06.23.19.10.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 19:10:51 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Ionela Voinescu , Viresh Kumar Cc: linux-pm@vger.kernel.org, Vincent Guittot , Qian Cai , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org Subject: [PATCH V3.1 1/4] cpufreq: cppc: Fix potential memleak in cppc_cpufreq_cpu_init Date: Thu, 24 Jun 2021 07:40:45 +0530 Message-Id: <445b58405e81d996fb4037223b9e81fc258a07ea.1624500522.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 In-Reply-To: <579689469ed8a7dfd68dcbb41e9191472799a326.1624266901.git.viresh.kumar@linaro.org> References: <579689469ed8a7dfd68dcbb41e9191472799a326.1624266901.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's a classic example of memleak, we allocate something, we fail and never free the resources. Make sure we free all resources on policy ->init() failures. Fixes: a28b2bfc099c ("cppc_cpufreq: replace per-cpu data array with a list") Tested-by: Vincent Guittot Signed-off-by: Viresh Kumar --- V3->V3.1: - Updated "if (!ret)" to "if (ret)", the more commonly used format. drivers/cpufreq/cppc_cpufreq.c | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c index be4f62e2c5f1..945ab4942c1c 100644 --- a/drivers/cpufreq/cppc_cpufreq.c +++ b/drivers/cpufreq/cppc_cpufreq.c @@ -256,6 +256,16 @@ static struct cppc_cpudata *cppc_cpufreq_get_cpu_data(unsigned int cpu) return NULL; } +static void cppc_cpufreq_put_cpu_data(struct cpufreq_policy *policy) +{ + struct cppc_cpudata *cpu_data = policy->driver_data; + + list_del(&cpu_data->node); + free_cpumask_var(cpu_data->shared_cpu_map); + kfree(cpu_data); + policy->driver_data = NULL; +} + static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) { unsigned int cpu = policy->cpu; @@ -309,7 +319,8 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) default: pr_debug("Unsupported CPU co-ord type: %d\n", policy->shared_type); - return -EFAULT; + ret = -EFAULT; + goto out; } /* @@ -324,10 +335,16 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) cpu_data->perf_ctrls.desired_perf = caps->highest_perf; ret = cppc_set_perf(cpu, &cpu_data->perf_ctrls); - if (ret) + if (ret) { pr_debug("Err setting perf value:%d on CPU:%d. ret:%d\n", caps->highest_perf, cpu, ret); + goto out; + } + + return 0; +out: + cppc_cpufreq_put_cpu_data(policy); return ret; } @@ -345,12 +362,7 @@ static int cppc_cpufreq_cpu_exit(struct cpufreq_policy *policy) pr_debug("Err setting perf value:%d on CPU:%d. ret:%d\n", caps->lowest_perf, cpu, ret); - /* Remove CPU node from list and free driver data for policy */ - free_cpumask_var(cpu_data->shared_cpu_map); - list_del(&cpu_data->node); - kfree(policy->driver_data); - policy->driver_data = NULL; - + cppc_cpufreq_put_cpu_data(policy); return 0; } -- 2.31.1.272.g89b43f80a514