From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
To: Pavel Machek <pavel@suse.cz>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
trenn@suse.de, thoenig@suse.de, Greg KH <gregkh@suse.de>
Subject: Re: [RFC] [PATCH] Execute PCI quirks on resume from suspend-to-RAM
Date: Wed, 10 May 2006 12:30:34 +0200 [thread overview]
Message-ID: <4461C0CA.8080803@gmx.net> (raw)
In-Reply-To: <20060510093942.GA12259@elf.ucw.cz>
Pavel Machek wrote:
> Hi!
>
>> machines with the asus_hides_smbus "feature" have the problem
>> that the smbus is disabled again after suspend-to-RAM. This
>> causes all sorts of problems, the worst being a total fan
>> failure on my Samsung P35 notebook after STR and STD.
>
> What happens if we disable hiding altogether? ASUS decided software
> should not see smbus, perhaps they had a reason?
IIRC this was introduced only to keep older ms-windows versions
from complaining about hardware for which no driver existed.
Newer ms-windows versions seem to unhide the smbus like we do.
> If we decide that we want to keep unhiding, redoing quirks after
> resume is probably neccessary...
Yes. Now the question is where exactly we want to execute these
quirks. Before or after restoring pci config space? If we do it
before restoring config space, it might cause some yet unknown
side effects. If we do it after restoring config space, it might
be worse because we would restore config space of a device not
existing anymore.
Thinking about it again, if we restored the full pci config space
on resume, this quirk handling would be completely unnecessary.
Any reasons why we don't do that?
>> References: Novell bugzilla #173420.
>>
>> This (totally ugly) patch fixes it.
>> Comments/criticism welcome.
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
>
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
next prev parent reply other threads:[~2006-05-10 10:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 0:55 [RFC] [PATCH] Execute PCI quirks on resume from suspend-to-RAM Carl-Daniel Hailfinger
2006-05-10 9:39 ` Pavel Machek
2006-05-10 10:30 ` Carl-Daniel Hailfinger [this message]
2006-05-10 20:56 ` Greg KH
2006-05-10 21:36 ` Carl-Daniel Hailfinger
2006-05-11 2:31 ` Dave Jones
2006-05-11 4:01 ` Carl-Daniel Hailfinger
2006-05-11 15:17 ` Carl-Daniel Hailfinger
2006-05-11 15:28 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4461C0CA.8080803@gmx.net \
--to=c-d.hailfinger.devel.2006@gmx.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=thoenig@suse.de \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).