From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Nick Piggin <npiggin@suse.de>,
paulmck@us.ibm.com, benh@kernel.crashing.org,
Paul.McKenney@us.ibm.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [patch 3/3] radix-tree: RCU lockless readside
Date: Fri, 23 Jun 2006 18:41:46 +1000 [thread overview]
Message-ID: <449BA94A.4030603@yahoo.com.au> (raw)
In-Reply-To: <449BA8BB.3070402@yahoo.com.au>
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
Nick Piggin wrote:
>> shift -= RADIX_TREE_MAP_SHIFT;
>> - slot = slot->slots[i];
>> + slot = rcu_dereference(slot->slots[i]);
>> + if (slot == NULL);
>> + break;
>> }
>
>
> ^^^^^^^^
>
> Up there.
>
And here's the patch.
--
SUSE Labs, Novell Inc.
[-- Attachment #2: radix-tree-paul-review-fix.patch --]
[-- Type: text/plain, Size: 376 bytes --]
Index: linux-2.6/lib/radix-tree.c
===================================================================
--- linux-2.6.orig/lib/radix-tree.c
+++ linux-2.6/lib/radix-tree.c
@@ -752,7 +752,7 @@ __lookup_tag(struct radix_tree_node *slo
}
shift -= RADIX_TREE_MAP_SHIFT;
slot = rcu_dereference(slot->slots[i]);
- if (slot == NULL);
+ if (slot == NULL)
break;
}
out:
next prev parent reply other threads:[~2006-06-23 8:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 14:48 [patch 0/3] 2.6.17 radix-tree: updates and lockless Nick Piggin
2006-06-20 14:48 ` [patch 1/3] radix-tree: direct data Nick Piggin
2006-06-20 14:48 ` [patch 2/3] radix-tree: small Nick Piggin
2006-06-20 14:48 ` [patch 3/3] radix-tree: RCU lockless readside Nick Piggin
2006-06-22 1:49 ` Paul E. McKenney
2006-06-22 15:45 ` Nick Piggin
2006-06-22 16:30 ` Paul E. McKenney
[not found] ` <20060622165551.GB23109@wotan.suse.de>
[not found] ` <20060622174057.GF1295@us.ibm.com>
2006-06-22 18:11 ` Nick Piggin
2006-06-23 7:09 ` Andrew Morton
2006-06-23 8:03 ` Nick Piggin
2006-06-23 8:39 ` Nick Piggin
2006-06-23 8:41 ` Nick Piggin [this message]
2006-06-22 18:23 ` Userspace RCU+rtth hack (was Re: [patch 3/3] radix-tree: RCU lockless readside) Nick Piggin
2006-06-22 20:25 ` Paul E. McKenney
2006-06-24 10:20 ` Nick Piggin
2006-06-24 15:55 ` Joe Seigh
2006-06-20 22:08 ` [patch 0/3] 2.6.17 radix-tree: updates and lockless Benjamin Herrenschmidt
2006-06-20 22:35 ` Andrew Morton
2006-06-20 23:09 ` Benjamin Herrenschmidt
2006-06-20 23:30 ` Andrew Morton
2006-06-20 23:50 ` Benjamin Herrenschmidt
2006-06-21 0:34 ` Christoph Lameter
2006-06-21 0:47 ` Benjamin Herrenschmidt
2006-06-21 1:07 ` Christoph Lameter
2006-06-21 1:33 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449BA94A.4030603@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=Paul.McKenney@us.ibm.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).