From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Pantelis Antoniou <panto@antoniou-consulting.com>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] of: Kconfig: OF_OVERLAY, select OF_EARLY_FLATTREE
Date: Thu, 1 Mar 2018 08:14:04 -0800 [thread overview]
Message-ID: <449f7ec6-e07b-7787-92c2-55b9404baa1c@gmail.com> (raw)
In-Reply-To: <d0e5e07b-cdf8-0cbc-d073-7f8982433c7f@gmail.com>
On 02/28/18 13:44, Frank Rowand wrote:
> On 02/28/18 12:26, Rob Herring wrote:
>> Sorry for the delay, been away for a few days.
>>
>> On Mon, Feb 19, 2018 at 12:24 AM, Frank Rowand <frowand.list@gmail.com> wrote:
>>>
>>> On 02/18/18 17:46, Rob Herring wrote:
>>>> On Sun, Feb 18, 2018 at 6:29 PM, <frowand.list@gmail.com> wrote:
>>>>> From: Frank Rowand <frank.rowand@sony.com>
>>>>>
>>>>> kbuild test robot reported a new warning for a recent patch:
>>>>>>> drivers/of/overlay.c:832:2: error: implicit declaration of function 'of_fdt_unflatten_tree' [-Werror=implicit-function-declaration]
>>>>> of_fdt_unflatten_tree(new_fdt, NULL, &overlay_root);
>>>>>
>>>>> The cause is that the prototype for of_fdt_unflatten_tree() in
>>>>> include/linux/of_fdt.c is guarded by OF_EARLY_FLATTREE.
>>
>> Umm, this is not true. of_fdt_unflatten_tree is outside the ifdef for
>> OF_EARLY_FLATTREE.
>
> Brown paper bag. :-( As you note below, CONFIG_OF_FLATTREE is the
> relevant option.
< snip >
> function, so it seems all is OK from that angle. But all use of overlays
> for many previous releases requires manually selecting OF_FLATTREE, given
> that FDTs have been the overlay source.
I was not correct about needing to manually select OF_FLATTREE. For
the unittest of overlays, which did the overlay unflattening, OF_UNITTEST
selected (selects until my other patch series) OF_EARLY_FLATTREE, which
selects OF_FLATTREE.
-Frank
prev parent reply other threads:[~2018-03-01 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 0:29 [PATCH] of: Kconfig: OF_OVERLAY, select OF_EARLY_FLATTREE frowand.list
2018-02-19 1:46 ` Rob Herring
2018-02-19 6:24 ` Frank Rowand
2018-02-28 20:26 ` Rob Herring
2018-02-28 21:44 ` Frank Rowand
2018-03-01 16:14 ` Frank Rowand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449f7ec6-e07b-7787-92c2-55b9404baa1c@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=panto@antoniou-consulting.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).