From: Suman Anna <s-anna@ti.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>, Arnd Bergmann <arnd@arndb.de>,
<linux-remoteproc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] remoteproc/keystone: Fix circular dependencies for ARM configs
Date: Wed, 28 Jun 2017 11:20:55 -0500 [thread overview]
Message-ID: <44a4b1bd-5faa-3b0e-1144-9bec0e3ad5cb@ti.com> (raw)
In-Reply-To: <20170627234047.GN18666@tuxbook>
On 06/27/2017 06:40 PM, Bjorn Andersson wrote:
> On Tue 27 Jun 15:46 PDT 2017, Suman Anna wrote:
>
>> Drop the dependency on RESET_CONTROLLER for the Keystone remoteproc
>> driver to resolve some circular dependencies around different choices
>> for RESET_CONTROLLER on common ARM configs. This dependency is
>> inherent as the RESET_CONTROLLER will be enabled due to the enabled
>> ARCH_HAS_RESET_CONTROLLER for ARCH_KEYSTONE.
>>
>
> As my approach requires synchronized changes to rproc-next and
> rpmsg-next and we're close to the merge window I'll pick this
> "workaround" for now, thanks!
>
> I do think it's appropriate for the Keystone remoteproc driver to
> express its dependency on reset-controller, so I intend to revert this
> as I look into this issue after -rc1 again.
>
> Merged all 4 patches.
Great, thanks.
regards
Suman
>
> Regards,
> Bjorn
>
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>> drivers/remoteproc/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
>> index 945c1574f896..8891a8e50f12 100644
>> --- a/drivers/remoteproc/Kconfig
>> +++ b/drivers/remoteproc/Kconfig
>> @@ -70,7 +70,6 @@ config DA8XX_REMOTEPROC
>> config KEYSTONE_REMOTEPROC
>> tristate "Keystone Remoteproc support"
>> depends on ARCH_KEYSTONE
>> - depends on RESET_CONTROLLER
>> select RPMSG_VIRTIO
>> help
>> Say Y here here to support Keystone remote processors (DSP)
>> --
>> 2.13.1
>>
prev parent reply other threads:[~2017-06-28 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 22:46 [PATCH 0/4] Some remoteproc/rpmsg Kconfig cleanups Suman Anna
2017-06-27 22:46 ` [PATCH 1/4] rpmsg: Drop VIRTUALIZATION dependency from RPMSG_VIRTIO Suman Anna
2017-06-27 22:46 ` [PATCH 2/4] remoteproc: Drop VIRTUALIZATION dependency from REMOTEPROC Suman Anna
2017-06-27 22:46 ` [PATCH 3/4] remoteproc: Drop redundant REMOTEPROC dependency from driver Kconfigs Suman Anna
2017-06-27 22:46 ` [PATCH 4/4] remoteproc/keystone: Fix circular dependencies for ARM configs Suman Anna
2017-06-27 23:40 ` Bjorn Andersson
2017-06-28 16:20 ` Suman Anna [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44a4b1bd-5faa-3b0e-1144-9bec0e3ad5cb@ti.com \
--to=s-anna@ti.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).