From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92636C4361B for ; Tue, 15 Dec 2020 12:50:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49894224D4 for ; Tue, 15 Dec 2020 12:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728786AbgLOMuK (ORCPT ); Tue, 15 Dec 2020 07:50:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:20362 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726156AbgLOMuJ (ORCPT ); Tue, 15 Dec 2020 07:50:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608036522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=71TJz4jJBxi3FNWgBuXMogBmrKtRgJQf0Py8VByy0QY=; b=b3BcZayerw/msP7wtSFaPWjoH0zFd6o2orNe78KKzqY0/lq+ddUSGMH7Un4Eqv06xFJztM HZmdfvKlKBYARGayOuhAhGgo5h2A6Bx6+3kBoZ3h5eeaMxXAVPKVPL1EJgN0VdPKR/JNRE wusKA13m0F8HdbjGyMCZAwoeVQR0EOo= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-32-R_UuDorSPnWdlo8FeiNZAA-1; Tue, 15 Dec 2020 07:48:40 -0500 X-MC-Unique: R_UuDorSPnWdlo8FeiNZAA-1 Received: by mail-ej1-f69.google.com with SMTP id y14so5964521ejf.11 for ; Tue, 15 Dec 2020 04:48:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=71TJz4jJBxi3FNWgBuXMogBmrKtRgJQf0Py8VByy0QY=; b=Rj74nP1OajM0L/oy8W6MdbiakFIt7aNDuL3LHeFuMTXImHwjws8x3NrLCJ9+q59hgq /aAyw300r43f4TKKnnzGnYMnFwI8HQelTDyvQ/zt1+p9W+7g6DfOOk2FZ3tzbDLgZfNT 8nls30vz9pVdztGRZRMh1TofIgLQutBBelzbiQJHXf3IP3FDTM4F93Llrlcnm7zCQztY hBC0otKW0/AjgHCFQE0HcJ3ahIdn7nYJI2gLJE3cMC4+Q6qjyVm1zAoCsfDOX4GWOziS y9u+moRUJ+BHpr6bflpYdjEv4Rh+KdmN64LBFSQ19PB5ImFfuT7/NIZAyTKo8+ZFH5k2 o8NA== X-Gm-Message-State: AOAM532eNWsVuSkngnR3f3YkhCyzAr9fo8sDTspqmndaXHNLp6P2m20G 0SD7ZiakzsBeMxbWcIZcRilNZIPoV+gToMHF0QtY4ylu8dFd4NEZl3udjsA8PvKvCgDq5yiHrhy sG3F/ZJVUlC/fylW3A6KCwaY3 X-Received: by 2002:aa7:dd17:: with SMTP id i23mr2260449edv.14.1608036519049; Tue, 15 Dec 2020 04:48:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJyW4i0eBs12UuBv1hAbzp9cwH5eerH26Zv/FHBRnZAh2dyaOq2xvRcezNZM9oglVXwzs9HqyQ== X-Received: by 2002:aa7:dd17:: with SMTP id i23mr2260432edv.14.1608036518858; Tue, 15 Dec 2020 04:48:38 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id cb14sm1346737ejb.105.2020.12.15.04.48.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Dec 2020 04:48:38 -0800 (PST) Subject: Re: [PATCH v5 0/4] Improve s0ix flows for systems i219LM To: Mario Limonciello , Jeff Kirsher , Tony Nguyen , intel-wired-lan@lists.osuosl.org Cc: linux-kernel@vger.kernel.org, Netdev , Alexander Duyck , Jakub Kicinski , Sasha Netfin , Aaron Brown , Stefan Assmann , David Miller , darcari@redhat.com, Yijun.Shen@dell.com, Perry.Yuan@dell.com, anthony.wong@canonical.com References: <20201214192935.895174-1-mario.limonciello@dell.com> From: Hans de Goede Message-ID: <44b33670-7692-d6c1-3a65-61544ae4276c@redhat.com> Date: Tue, 15 Dec 2020 13:48:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201214192935.895174-1-mario.limonciello@dell.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 12/14/20 8:29 PM, Mario Limonciello wrote: > commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") > disabled s0ix flows for systems that have various incarnations of the > i219-LM ethernet controller. This was done because of some regressions > caused by an earlier > commit 632fbd5eb5b0e ("e1000e: fix S0ix flows for cable connected case") > with i219-LM controller. > > Per discussion with Intel architecture team this direction should be changed and > allow S0ix flows to be used by default. This patch series includes directional > changes for their conclusions in https://lkml.org/lkml/2020/12/13/15. > > Changes from v4 to v5: > - If setting S0ix to enabled in ethtool examine the hardware generation. > If running on hardware older than Cannon Point return an error. > - Increase ULP timeout to 2.5 seconds, but show a warning after 1 second. Thank you. I've given v5 a test on a Lenovo X1 Carbon 8th gen (AMT capable) and things work fine there with v5: Tested-by: Hans de Goede Regards, Hans > Changes from v3 to v4: > - Drop patch 1 for proper s0i3.2 entry, it was separated and is now merged in kernel > - Add patch to only run S0ix flows if shutdown succeeded which was suggested in > thread > - Adjust series for guidance from https://lkml.org/lkml/2020/12/13/15 > * Revert i219-LM disallow-list. > * Drop all patches for systems tested by Dell in an allow list > * Increase ULP timeout to 1000ms > Changes from v2 to v3: > - Correct some grammar and spelling issues caught by Bjorn H. > * s/s0ix/S0ix/ in all commit messages > * Fix a typo in commit message > * Fix capitalization of proper nouns > - Add more pre-release systems that pass > - Re-order the series to add systems only at the end of the series > - Add Fixes tag to a patch in series. > > Changes from v1 to v2: > - Directly incorporate Vitaly's dependency patch in the series > - Split out s0ix code into it's own file > - Adjust from DMI matching to PCI subsystem vendor ID/device matching > - Remove module parameter and sysfs, use ethtool flag instead. > - Export s0ix flag to ethtool private flags > - Include more people and lists directly in this submission chain. > > > Mario Limonciello (4): > e1000e: Only run S0ix flows if shutdown succeeded > e1000e: bump up timeout to wait when ME un-configures ULP mode > Revert "e1000e: disable s0ix entry and exit flows for ME systems" > e1000e: Export S0ix flags to ethtool > > drivers/net/ethernet/intel/e1000e/e1000.h | 1 + > drivers/net/ethernet/intel/e1000e/ethtool.c | 46 ++++++++++++++++ > drivers/net/ethernet/intel/e1000e/ich8lan.c | 16 ++++-- > drivers/net/ethernet/intel/e1000e/netdev.c | 59 ++++----------------- > 4 files changed, 70 insertions(+), 52 deletions(-) > > -- > 2.25.1 >