From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"maintainer:BROADCOM BCM63XX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Richard Cochran <richardcochran@gmail.com>,
Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM BCM63XX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson SoC support"
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH net-next v3 1/2] net: phy: replace PHY_HAS_INTERRUPT with a check for config_intr and ack_interrupt
Date: Fri, 9 Nov 2018 21:22:55 +0100 [thread overview]
Message-ID: <44b503b8-9f2a-50ac-c4c9-d25258d98ef5@gmail.com> (raw)
In-Reply-To: <20181109201307.GV5259@lunn.ch>
On 09.11.2018 21:13, Andrew Lunn wrote:
> Hi Heiner
>
>> +static bool phy_drv_supports_irq(struct phy_driver *phydrv)
>> +{
>> + return phydrv->config_intr || phydrv->ack_interrupt;
>> +}
>
> Should this be && not || ? I thought both needed to be provided for
> interrupts to work.
>
> Andrew
>
I've seen at least one driver which configures interrupts in
config_init and doesn't define a config_intr callback
(ack_interrupt callback is there)
Intention of this check is not to ensure that the driver defines
everything to make interrupts work. All it states:
If at least one of the irq-related callbacks is defined, then
we interpret this as indicator that the PHY supports interrupts.
Heiner
next prev parent reply other threads:[~2018-11-09 20:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 17:15 [PATCH net-next v3 0/2] net: phy: replace PHY_HAS_INTERRUPT with a check for config_intr and ack_interrupt Heiner Kallweit
2018-11-09 17:16 ` [PATCH net-next v3 1/2] " Heiner Kallweit
2018-11-09 20:13 ` Andrew Lunn
2018-11-09 20:22 ` Heiner Kallweit [this message]
2018-11-09 20:33 ` Florian Fainelli
2018-11-09 20:56 ` Heiner Kallweit
2018-11-12 20:32 ` Martin Blumenstingl
2018-11-12 20:38 ` Heiner Kallweit
2018-11-12 21:53 ` Martin Blumenstingl
2018-11-09 20:38 ` Andrew Lunn
2018-11-09 17:17 ` [PATCH net-next v3 2/2] net: phy: remove flag PHY_HAS_INTERRUPT from driver configs Heiner Kallweit
2018-11-09 20:13 ` Andrew Lunn
2018-11-11 17:38 ` [PATCH net-next v3 0/2] net: phy: replace PHY_HAS_INTERRUPT with a check for config_intr and ack_interrupt David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44b503b8-9f2a-50ac-c4c9-d25258d98ef5@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=carlo@caione.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).