From: Randy Dunlap <rdunlap@infradead.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>, Sasha Levin <sashal@kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the hyperv-fixes tree
Date: Sun, 14 Jul 2019 08:02:11 -0700 [thread overview]
Message-ID: <44b7e61d-438d-e906-57fd-b1182bf6f6c6@infradead.org> (raw)
In-Reply-To: <20190714225534.1dc093ad@canb.auug.org.au>
On 7/14/19 5:55 AM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 2e6d7851bdeb ("PCI: pci-hyperv: fix build errors on non-SYSFS config")
>
> Fixes tag
>
> Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot
oops, copy-paste error.
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than one line. Also do not
> include blank lines among the tag lines.
Hm, so you are saying that the Fixes: line should not be separated from the
other tag lines? That's news to me...
Should Fixes: be before the other tag lines or does it matter?
thanks.
--
~Randy
next prev parent reply other threads:[~2019-07-14 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 12:55 linux-next: Fixes tag needs some work in the hyperv-fixes tree Stephen Rothwell
2019-07-14 15:02 ` Randy Dunlap [this message]
2019-07-14 22:01 ` Stephen Rothwell
2019-07-16 11:20 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44b7e61d-438d-e906-57fd-b1182bf6f6c6@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).