From: Markus Elfring <Markus.Elfring@web.de>
To: Wen Yang <wen.yang99@zte.com.cn>, cocci@systeme.lip6.fr
Cc: Yi Wang <wang.yi59@zte.com.cn>,
Julia Lawall <julia.lawall@lip6.fr>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kernel@vger.kernel.org
Subject: Re: [v2] coccinelle: semantic code search for missing of_node_put
Date: Thu, 4 Jul 2019 07:40:41 +0200 [thread overview]
Message-ID: <44be5924-26ca-5106-aa25-3cbc3343aa2c@web.de> (raw)
In-Reply-To: <201907041041053843118@zte.com.cn>
> We will also provide an example written in Python later.
Will the code move from the commit description into a file
for your next patch version?
> We first use this script to find out all the function names to be processed,
I am still curious on how the output format selection will become clearer
for the potentially desired automatic data conversion.
> and then copy these function names into r1.
Would this action be performed by another software build script?
>>> +@initialize:python@
>>> +@@
>>> +
>>> +seen = set()
>>> +
>>> +def add_if_not_present (p1, p2):
>>
>> It seems that you would like to use iteration functionality.
I am waiting on another constructive answer for this implementation detail.
>>> +x = @p1\(of_find_all_nodes\|
>>
>> I would find this SmPL disjunction easier to read without the usage
>> of extra backslashes.
>>
>> +x =
>> +(of_…
>> +|of_…
>> +)@p1(...);
>>
>>
>> Which sort criteria were applied for the generation of the shown
>> function name list?
>
> As julia pointed out, your current writing is not compiled.
* It can be needed for a while to specify the mentioned position variable
at an other place.
* Would you like to adjust the SmPL coding style here?
* Will the application of sort criteria be clarified for such identifier lists?
>>> +if (x == NULL || ...) S
>>> +... when != e = (T)x
>>> + when != true x == NULL
…
> Our previous version used the "when any" clause, so we need
> "when != true x == NULL".
I suggest to reconsider further aspects for such constraints.
> We can delete this code exclusion specification for this version.
I would find another assignment exclusion more appropriate at this place.
Regards,
Markus
next parent reply other threads:[~2019-07-04 5:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201907041041053843118@zte.com.cn>
2019-07-04 5:40 ` Markus Elfring [this message]
[not found] <201907051357245235750@zte.com.cn>
2019-07-05 6:17 ` [PATCH v2] coccinelle: semantic code search formissingof_node_put Julia Lawall
2019-07-05 6:45 ` [v2] coccinelle: semantic code search for missing of_node_put Markus Elfring
[not found] <201907041103003504524@zte.com.cn>
2019-07-04 6:28 ` Markus Elfring
2019-06-28 2:58 [PATCH v2] " Wen Yang
2019-06-28 9:38 ` Markus Elfring
2019-06-28 11:07 ` Julia Lawall
2019-06-28 14:16 ` [v2] " Markus Elfring
2019-06-28 14:16 ` Markus Elfring
2019-06-29 7:40 ` Markus Elfring
2019-06-29 7:49 ` Julia Lawall
2019-06-29 8:35 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44be5924-26ca-5106-aa25-3cbc3343aa2c@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).