From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3DF8C4CEC5 for ; Thu, 12 Sep 2019 15:34:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95CFC20856 for ; Thu, 12 Sep 2019 15:34:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733075AbfILPeb (ORCPT ); Thu, 12 Sep 2019 11:34:31 -0400 Received: from smtprelay0247.hostedemail.com ([216.40.44.247]:35895 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732699AbfILPeb (ORCPT ); Thu, 12 Sep 2019 11:34:31 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id E876C18224D65; Thu, 12 Sep 2019 15:34:29 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: room66_4419114b8213b X-Filterd-Recvd-Size: 2754 Received: from XPS-9350.home (unknown [47.151.152.152]) (Authenticated sender: joe@perches.com) by omf09.hostedemail.com (Postfix) with ESMTPA; Thu, 12 Sep 2019 15:34:27 +0000 (UTC) Message-ID: <44c08faf43fa77fb271f8dbb579079fb09007716.camel@perches.com> Subject: Re: [Ksummit-discuss] [PATCH v2 0/3] Maintainer Entry Profiles From: Joe Perches To: Bart Van Assche , "Martin K. Petersen" , Dan Williams Cc: Dave Jiang , ksummit-discuss@lists.linuxfoundation.org, linux-nvdimm@lists.01.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Dmitry Vyukov , Vishal Verma , Mauro Carvalho Chehab , Steve French , "Tobin C. Harding" Date: Thu, 12 Sep 2019 08:34:26 -0700 In-Reply-To: <6fe45562-9493-25cf-afdb-6c0e702a49b4@acm.org> References: <156821692280.2951081.18036584954940423225.stgit@dwillia2-desk3.amr.corp.intel.com> <6fe45562-9493-25cf-afdb-6c0e702a49b4@acm.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-09-12 at 14:31 +0100, Bart Van Assche wrote: > On 9/11/19 5:40 PM, Martin K. Petersen wrote: > > * Do not use custom To: and Cc: for individual patches. We want to see the > > whole series, even patches that potentially need to go through a different > > subsystem tree. That's not currently feasible when cc'ing any vger.kernel.org list as those lists have a maximum email header size and patches that span multiple subsystems can have very long to: and cc: lists. > > * The patch must compile without warnings (make C=1 CF="-D__CHECK_ENDIAN__") > > and does not incur any zeroday test robot complaints. > > How about adding W=1 to that make command? That's rather too compiler version dependent and new warnings frequently get introduced by new compiler versions. > How about existing drivers that trigger tons of endianness warnings, > e.g. qla2xxx? How about requiring that no new warnings are introduced? Adding a sparse clean C=2 requirement might be useful. > > * The patch must have a commit message that describes, comprehensively and in > > plain English, what the patch does. > > How about making this requirement more detailed and requiring that not > only what has been changed is document but also why that change has been > made? I believe the "why" is rather more important than the "how" and should be the primary thing described in the commit message.