From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: (EXT) Re: [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44
Date: Wed, 10 Jun 2020 17:26:23 +0200 [thread overview]
Message-ID: <44d3b82a11fc292f0aa3f60a8ccebd4e8ce5d3e8.camel@ew.tq-group.com> (raw)
In-Reply-To: <20200610145954.GA135509@ravnborg.org>
On Wed, 2020-06-10 at 16:59 +0200, Sam Ravnborg wrote:
> Hi Matthias.
>
> Thanks, a few details you need to fix. See below.
>
> Sam
>
> On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote:
> > From: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
> >
> > Add support for the CDTech Electronics displays S070PWS19HP-FC21
> > (7.0" WSVGA) and S070SWV29HG-DC44 (7.0" WVGA) to panel-simple.
> >
> > Signed-off-by: Michael Krummsdorf <michael.krummsdorf@tq-group.com>
> > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com
> > >
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 60
> > ++++++++++++++++++++++++++++
> > 1 file changed, 60 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > b/drivers/gpu/drm/panel/panel-simple.c
> > index b6ecd1552132..1673113e5a5a 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1315,6 +1315,60 @@ static const struct panel_desc
> > cdtech_s043wq26h_ct7 = {
> > .bus_flags = DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> > };
> >
> > +/* S070PWS19HP-FC21 2017/04/22 */
> > +static const struct drm_display_mode cdtech_s070pws19hp_fc21_mode
> > = {
> > + .clock = 51200,
> > + .hdisplay = 1024,
> > + .hsync_start = 1024 + 160,
> > + .hsync_end = 1024 + 160 + 20,
> > + .htotal = 1024 + 160 + 20 + 140,
> > + .vdisplay = 600,
> > + .vsync_start = 600 + 12,
> > + .vsync_end = 600 + 12 + 3,
> > + .vtotal = 600 + 12 + 3 + 20,
> > + .vrefresh = 60,
>
> .vrefresh is no longer present, please drop.
I based my patches on the branch drm-next of
https://cgit.freedesktop.org/drm/drm, should I have used a different
branch?
> > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> > +};
> > +
> > +static const struct panel_desc cdtech_s070pws19hp_fc21 = {
> > + .modes = &cdtech_s070pws19hp_fc21_mode,
> > + .num_modes = 1,
> > + .bpc = 6,
> > + .size = {
> > + .width = 154,
> > + .height = 86,
> > + },
> > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > + .bus_flags = DRM_BUS_FLAG_DE_HIGH |
> > DRM_BUS_FLAG_PIXDATA_POSEDGE,
> > +};
>
> Please add .connector_type - it is mandatory.
> > +
> > +/* S070SWV29HG-DC44 2017/09/21 */
> > +static const struct drm_display_mode cdtech_s070swv29hg_dc44_mode
> > = {
> > + .clock = 33300,
> > + .hdisplay = 800,
> > + .hsync_start = 800 + 210,
> > + .hsync_end = 800 + 210 + 2,
> > + .htotal = 800 + 210 + 2 + 44,
> > + .vdisplay = 480,
> > + .vsync_start = 480 + 22,
> > + .vsync_end = 480 + 22 + 2,
> > + .vtotal = 480 + 22 + 2 + 21,
> > + .vrefresh = 60,
>
> .vrefresh is no longer present, please drop.
> > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> > +};
> > +
> > +static const struct panel_desc cdtech_s070swv29hg_dc44 = {
> > + .modes = &cdtech_s070swv29hg_dc44_mode,
> > + .num_modes = 1,
> > + .bpc = 6,
> > + .size = {
> > + .width = 154,
> > + .height = 86,
> > + },
> > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > + .bus_flags = DRM_BUS_FLAG_DE_HIGH |
> > DRM_BUS_FLAG_PIXDATA_POSEDGE,
>
> Please add .connector_type - it is mandatory.
> > +};
> > +
> > static const struct drm_display_mode cdtech_s070wv95_ct16_mode = {
> > .clock = 35000,
> > .hdisplay = 800,
> > @@ -3723,6 +3777,12 @@ static const struct of_device_id
> > platform_of_match[] = {
> > }, {
> > .compatible = "cdtech,s043wq26h-ct7",
> > .data = &cdtech_s043wq26h_ct7,
> > + }, {
> > + .compatible = "cdtech,s070pws19hp-fc21",
> > + .data = &cdtech_s070pws19hp_fc21,
> > + }, {
> > + .compatible = "cdtech,s070swv29hg-dc44",
> > + .data = &cdtech_s070swv29hg_dc44,
> > }, {
> > .compatible = "cdtech,s070wv95-ct16",
> > .data = &cdtech_s070wv95_ct16,
> > --
> > 2.17.1
next prev parent reply other threads:[~2020-06-10 15:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 12:01 [PATCH 0/4] panel-simple: CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44, Tianma TM070JVHG33 Matthias Schiffer
2020-06-10 12:01 ` [PATCH 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
2020-06-10 12:01 ` [PATCH 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33 Matthias Schiffer
2020-06-10 12:01 ` [PATCH 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
2020-06-10 14:59 ` Sam Ravnborg
2020-06-10 15:26 ` Matthias Schiffer [this message]
2020-06-10 16:02 ` (EXT) " Sam Ravnborg
2020-06-15 21:20 ` Emil Velikov
2020-06-10 12:01 ` [PATCH 4/4] drm/panel: simple: add Tianma TM070JVHG33 Matthias Schiffer
2020-06-10 15:00 ` Sam Ravnborg
2020-06-11 12:42 ` [PATCH v2 1/4] dt-bindings: display: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
2020-06-11 12:46 ` Matthias Schiffer
2020-06-11 19:48 ` Sam Ravnborg
2020-06-11 12:42 ` [PATCH v2 2/4] dt-bindings: display: simple: add Tianma TM070JVHG33 Matthias Schiffer
2020-06-11 12:42 ` [PATCH v2 3/4] drm/panel: simple: add CDTech S070PWS19HP-FC21 and S070SWV29HG-DC44 Matthias Schiffer
2020-06-11 12:42 ` [PATCH v2 4/4] drm/panel: simple: add Tianma TM070JVHG33 Matthias Schiffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44d3b82a11fc292f0aa3f60a8ccebd4e8ce5d3e8.camel@ew.tq-group.com \
--to=matthias.schiffer@ew.tq-group.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).