linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Qian Cai <cai@redhat.com>
To: Will Deacon <will@kernel.org>
Cc: paulmck@kernel.org, catalin.marinas@arm.com,
	kernel-team@android.com, Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier
Date: Fri, 06 Nov 2020 07:48:59 -0500	[thread overview]
Message-ID: <44d61059f01188afd833b0e889a360cd4189f293.camel@redhat.com> (raw)
In-Reply-To: <20201106103755.GA9729@willie-the-truck>

On Fri, 2020-11-06 at 10:37 +0000, Will Deacon wrote:
> > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> > index 09c96f57818c..10729d2d6084 100644
> > --- a/arch/arm64/kernel/smp.c
> > +++ b/arch/arm64/kernel/smp.c
> > @@ -421,6 +421,8 @@ void cpu_die_early(void)
> >  
> >  	update_cpu_boot_status(CPU_STUCK_IN_KERNEL);
> >  
> > +	rcu_report_dead(cpu);
> 
> I think this is in the wrong place, see:
> 
> https://lore.kernel.org/r/20201106103602.9849-1-will@kernel.org
> 
> which seems to fix the problem for me.
Ah, I had not realized that cpu_psci_cpu_die() could no return. Your patchset
looks good to me.


      reply	other threads:[~2020-11-06 12:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 18:26 [PATCH] arm64/smp: Move rcu_cpu_starting() earlier Qian Cai
2020-10-28 21:00 ` Paul E. McKenney
2020-10-29  9:10 ` Will Deacon
2020-10-29 13:17   ` Qian Cai
2020-10-30  8:15     ` Will Deacon
2020-10-29 14:09   ` Paul E. McKenney
2020-10-30 16:33 ` Will Deacon
2020-11-05 22:22   ` Will Deacon
2020-11-05 23:02     ` Qian Cai
2020-11-05 23:28       ` Paul E. McKenney
2020-11-06  2:15         ` Qian Cai
2020-11-06  4:07           ` Paul E. McKenney
2020-11-06 10:37           ` Will Deacon
2020-11-06 12:48             ` Qian Cai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44d61059f01188afd833b0e889a360cd4189f293.camel@redhat.com \
    --to=cai@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).