From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D164AC433DB for ; Tue, 2 Feb 2021 15:37:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A970C64F6D for ; Tue, 2 Feb 2021 15:37:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235556AbhBBPhB (ORCPT ); Tue, 2 Feb 2021 10:37:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235595AbhBBPex (ORCPT ); Tue, 2 Feb 2021 10:34:53 -0500 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12E37C061573; Tue, 2 Feb 2021 07:33:57 -0800 (PST) Received: from [2a04:4540:1400:7bac::c66] by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1l6xgg-0002VE-45; Tue, 02 Feb 2021 16:33:54 +0100 Subject: Re: [PATCH v2 2/2] irqchip: Add support for Realtek RTL838x/RTL839x IRQ controller To: Bert Vermeulen , Thomas Gleixner , Marc Zyngier , Rob Herring , Birger Koblitz , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20210104131755.2979203-1-bert@biot.com> <20210104131755.2979203-3-bert@biot.com> From: John Crispin Message-ID: <44d6de52-5422-1138-cb00-21320668eb29@phrozen.org> Date: Tue, 2 Feb 2021 16:33:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210104131755.2979203-3-bert@biot.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.01.21 14:17, Bert Vermeulen wrote: > This is a standard IRQ driver with only status and mask registers. > > The mapping from SoC interrupts (18-31) to MIPS core interrupts is > done via an interrupt-map in device tree. > > Signed-off-by: Bert Vermeulen Signed-off-by: John Crispin > --- > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-realtek-rtl.c | 180 ++++++++++++++++++++++++++++++ > 2 files changed, 181 insertions(+) > create mode 100644 drivers/irqchip/irq-realtek-rtl.c > > diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile > index 0ac93bfaec61..4fc1086bed7e 100644 > --- a/drivers/irqchip/Makefile > +++ b/drivers/irqchip/Makefile > @@ -113,3 +113,4 @@ obj-$(CONFIG_LOONGSON_PCH_PIC) += irq-loongson-pch-pic.o > obj-$(CONFIG_LOONGSON_PCH_MSI) += irq-loongson-pch-msi.o > obj-$(CONFIG_MST_IRQ) += irq-mst-intc.o > obj-$(CONFIG_SL28CPLD_INTC) += irq-sl28cpld.o > +obj-$(CONFIG_MACH_REALTEK_RTL) += irq-realtek-rtl.o > diff --git a/drivers/irqchip/irq-realtek-rtl.c b/drivers/irqchip/irq-realtek-rtl.c > new file mode 100644 > index 000000000000..bafe9ee4a85a > --- /dev/null > +++ b/drivers/irqchip/irq-realtek-rtl.c > @@ -0,0 +1,180 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2006-2012 Tony Wu > + * Copyright (C) 2020 Birger Koblitz > + * Copyright (C) 2020 Bert Vermeulen > + * Copyright (C) 2020 John Crispin > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +/* Global Interrupt Mask Register */ > +#define RTL_ICTL_GIMR 0x00 > +/* Global Interrupt Status Register */ > +#define RTL_ICTL_GISR 0x04 > +/* Interrupt Routing Registers */ > +#define RTL_ICTL_IRR0 0x08 > +#define RTL_ICTL_IRR1 0x0c > +#define RTL_ICTL_IRR2 0x10 > +#define RTL_ICTL_IRR3 0x14 > + > +#define REG(x) (realtek_ictl_base + x) > + > +static DEFINE_RAW_SPINLOCK(irq_lock); > +static void __iomem *realtek_ictl_base; > + > +static void realtek_ictl_unmask_irq(struct irq_data *i) > +{ > + unsigned long flags; > + u32 value; > + > + raw_spin_lock_irqsave(&irq_lock, flags); > + > + value = readl(REG(RTL_ICTL_GIMR)); > + value |= BIT(i->hwirq); > + writel(value, REG(RTL_ICTL_GIMR)); > + > + raw_spin_unlock_irqrestore(&irq_lock, flags); > +} > + > +static void realtek_ictl_mask_irq(struct irq_data *i) > +{ > + unsigned long flags; > + u32 value; > + > + raw_spin_lock_irqsave(&irq_lock, flags); > + > + value = readl(REG(RTL_ICTL_GIMR)); > + value &= ~BIT(i->hwirq); > + writel(value, REG(RTL_ICTL_GIMR)); > + > + raw_spin_unlock_irqrestore(&irq_lock, flags); > +} > + > +static struct irq_chip realtek_ictl_irq = { > + .name = "realtek-rtl-intc", > + .irq_mask = realtek_ictl_mask_irq, > + .irq_unmask = realtek_ictl_unmask_irq, > +}; > + > +static int intc_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw) > +{ > + irq_set_chip_and_handler(hw, &realtek_ictl_irq, handle_level_irq); > + > + return 0; > +} > + > +static const struct irq_domain_ops irq_domain_ops = { > + .map = intc_map, > + .xlate = irq_domain_xlate_onecell, > +}; > + > +static void realtek_irq_dispatch(struct irq_desc *desc) > +{ > + struct irq_chip *chip = irq_desc_get_chip(desc); > + struct irq_domain *domain; > + unsigned int pending; > + > + chained_irq_enter(chip, desc); > + pending = readl(REG(RTL_ICTL_GIMR)) & readl(REG(RTL_ICTL_GISR)); > + if (unlikely(!pending)) { > + spurious_interrupt(); > + goto out; > + } > + domain = irq_desc_get_handler_data(desc); > + generic_handle_irq(irq_find_mapping(domain, __ffs(pending))); > + > +out: > + chained_irq_exit(chip, desc); > +} > + > +/* > + * SoC interrupts are cascaded to MIPS CPU interrupts according to the > + * interrupt-map in the device tree. Each SoC interrupt gets 4 bits for > + * the CPU interrupt in an Interrupt Routing Register. Max 32 SoC interrupts > + * thus go into 4 IRRs. > + */ > +static int __init map_interrupts(struct device_node *node) > +{ > + struct device_node *cpu_ictl; > + const __be32 *imap; > + u32 imaplen, soc_int, cpu_int, tmp, regs[4]; > + int ret, i, irr_regs[] = { > + RTL_ICTL_IRR3, > + RTL_ICTL_IRR2, > + RTL_ICTL_IRR1, > + RTL_ICTL_IRR0, > + }; > + > + ret = of_property_read_u32(node, "#address-cells", &tmp); > + if (ret || tmp) > + return -EINVAL; > + > + imap = of_get_property(node, "interrupt-map", &imaplen); > + if (!imap || imaplen % 3) > + return -EINVAL; > + > + memset(regs, 0, sizeof(regs)); > + for (i = 0; i < imaplen; i += 3 * sizeof(u32)) { > + soc_int = be32_to_cpup(imap); > + if (soc_int > 31) > + return -EINVAL; > + > + cpu_ictl = of_find_node_by_phandle(be32_to_cpup(imap + 1)); > + if (!cpu_ictl) > + return -EINVAL; > + ret = of_property_read_u32(cpu_ictl, "#interrupt-cells", &tmp); > + if (ret || tmp != 1) > + return -EINVAL; > + of_node_put(cpu_ictl); > + > + cpu_int = be32_to_cpup(imap + 2); > + if (cpu_int > 7) > + return -EINVAL; > + > + regs[(soc_int * 4) / 32] |= cpu_int << (soc_int * 4) % 32; > + imap += 3; > + } > + > + for (i = 0; i < 4; i++) > + writel(regs[i], REG(irr_regs[i])); > + > + return 0; > +} > + > +static int __init realtek_rtl_of_init(struct device_node *node, struct device_node *parent) > +{ > + struct irq_domain *domain; > + int ret; > + > + domain = irq_domain_add_simple(node, 32, 0, > + &irq_domain_ops, NULL); > + irq_set_chained_handler_and_data(2, realtek_irq_dispatch, domain); > + irq_set_chained_handler_and_data(3, realtek_irq_dispatch, domain); > + irq_set_chained_handler_and_data(4, realtek_irq_dispatch, domain); > + irq_set_chained_handler_and_data(5, realtek_irq_dispatch, domain); > + > + realtek_ictl_base = of_iomap(node, 0); > + if (!realtek_ictl_base) > + return -ENXIO; > + > + /* Disable all cascaded interrupts */ > + writel(0, REG(RTL_ICTL_GIMR)); > + > + ret = map_interrupts(node); > + if (ret) { > + pr_err("invalid interrupt map\n"); > + return ret; > + } > + > + /* Clear timer interrupt */ > + write_c0_compare(0); > + > + return 0; > +} > + > +IRQCHIP_DECLARE(realtek_rtl_intc, "realtek,rtl-intc", realtek_rtl_of_init);