From: Florian Fainelli <f.fainelli@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Marc Zyngier <maz@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irqchip: fix compile-testing without CONFIG_OF
Date: Fri, 22 Oct 2021 12:12:46 -0700 [thread overview]
Message-ID: <44f5f437-cd54-5881-e988-fcb9df8adea9@gmail.com> (raw)
In-Reply-To: <20211022154927.920491-1-arnd@kernel.org>
On 10/22/21 8:49 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Drivers using the new IRQCHIP_PLATFORM_DRIVER_BEGIN helper
> fail to link when compile-testing without CONFIG_OF,
> as that means CONFIG_IRQCHIP is disabled as well:
>
> ld.lld: error: undefined symbol: platform_irqchip_probe
>>>> referenced by irq-meson-gpio.c
>>>> irqchip/irq-meson-gpio.o:(meson_gpio_intc_driver) in archive drivers/built-in.a
>>>> referenced by irq-mchp-eic.c
>>>> irqchip/irq-mchp-eic.o:(mchp_eic_driver) in archive drivers/built-in.a
>
> As the drivers are not actually used in this case, just
> making the reference to this symbol conditional helps
> avoid the link failure.
>
> Fixes: f8410e626569 ("irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/END and IRQCHIP_MATCH helper macros")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-10-22 19:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 15:49 [PATCH] irqchip: fix compile-testing without CONFIG_OF Arnd Bergmann
2021-10-22 19:12 ` Florian Fainelli [this message]
2021-10-25 8:11 ` [irqchip: irq/irqchip-next] irqchip: Fix " irqchip-bot for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44f5f437-cd54-5881-e988-fcb9df8adea9@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).