linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] bus/fsl-mc: fix doc warning
@ 2021-06-07  3:53 ChenXiaoSong
  2021-06-07 12:17 ` Laurentiu Tudor
  0 siblings, 1 reply; 2+ messages in thread
From: ChenXiaoSong @ 2021-06-07  3:53 UTC (permalink / raw)
  To: stuyoder, laurentiu.tudor; +Cc: linux-kernel, yukuai3, yi.zhang, chenxiaosong2

Fix gcc W=1 warning:

drivers/bus/fsl-mc/dprc.c:345: warning: Function parameter or member 'attr' not described in 'dprc_get_attributes'
drivers/bus/fsl-mc/dprc.c:521: warning: Function parameter or member 'obj_type' not described in 'dprc_get_obj_region'

Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
---
 drivers/bus/fsl-mc/dprc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/fsl-mc/dprc.c b/drivers/bus/fsl-mc/dprc.c
index 27b0a01bad9b..c862e9119b4d 100644
--- a/drivers/bus/fsl-mc/dprc.c
+++ b/drivers/bus/fsl-mc/dprc.c
@@ -334,7 +334,7 @@ int dprc_clear_irq_status(struct fsl_mc_io *mc_io,
  * @mc_io:	Pointer to MC portal's I/O object
  * @cmd_flags:	Command flags; one or more of 'MC_CMD_FLAG_'
  * @token:	Token of DPRC object
- * @attributes	Returned container attributes
+ * @attr	Returned container attributes
  *
  * Return:     '0' on Success; Error code otherwise.
  */
@@ -504,7 +504,7 @@ EXPORT_SYMBOL_GPL(dprc_set_obj_irq);
  * @mc_io:	Pointer to MC portal's I/O object
  * @cmd_flags:	Command flags; one or more of 'MC_CMD_FLAG_'
  * @token:	Token of DPRC object
- * @obj_type;	Object type as returned in dprc_get_obj()
+ * @obj_type:	Object type as returned in dprc_get_obj()
  * @obj_id:	Unique object instance as returned in dprc_get_obj()
  * @region_index: The specific region to query
  * @region_desc:  Returns the requested region descriptor
-- 
2.25.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] bus/fsl-mc: fix doc warning
  2021-06-07  3:53 [PATCH -next] bus/fsl-mc: fix doc warning ChenXiaoSong
@ 2021-06-07 12:17 ` Laurentiu Tudor
  0 siblings, 0 replies; 2+ messages in thread
From: Laurentiu Tudor @ 2021-06-07 12:17 UTC (permalink / raw)
  To: ChenXiaoSong, stuyoder; +Cc: linux-kernel, yukuai3, yi.zhang

Hi,

On 6/7/2021 6:53 AM, ChenXiaoSong wrote:
> Fix gcc W=1 warning:
> 
> drivers/bus/fsl-mc/dprc.c:345: warning: Function parameter or member 'attr' not described in 'dprc_get_attributes'
> drivers/bus/fsl-mc/dprc.c:521: warning: Function parameter or member 'obj_type' not described in 'dprc_get_obj_region'
> 
> Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
> ---
>  drivers/bus/fsl-mc/dprc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/fsl-mc/dprc.c b/drivers/bus/fsl-mc/dprc.c
> index 27b0a01bad9b..c862e9119b4d 100644
> --- a/drivers/bus/fsl-mc/dprc.c
> +++ b/drivers/bus/fsl-mc/dprc.c
> @@ -334,7 +334,7 @@ int dprc_clear_irq_status(struct fsl_mc_io *mc_io,
>   * @mc_io:	Pointer to MC portal's I/O object
>   * @cmd_flags:	Command flags; one or more of 'MC_CMD_FLAG_'
>   * @token:	Token of DPRC object
> - * @attributes	Returned container attributes
> + * @attr	Returned container attributes
>   *
>   * Return:     '0' on Success; Error code otherwise.
>   */
> @@ -504,7 +504,7 @@ EXPORT_SYMBOL_GPL(dprc_set_obj_irq);
>   * @mc_io:	Pointer to MC portal's I/O object
>   * @cmd_flags:	Command flags; one or more of 'MC_CMD_FLAG_'
>   * @token:	Token of DPRC object
> - * @obj_type;	Object type as returned in dprc_get_obj()
> + * @obj_type:	Object type as returned in dprc_get_obj()
>   * @obj_id:	Unique object instance as returned in dprc_get_obj()
>   * @region_index: The specific region to query
>   * @region_desc:  Returns the requested region descriptor
> 


Thanks for the patch. This was already submitted [1] as part of a larger
series [2] by Lee Jones.

[1] https://lore.kernel.org/patchwork/patch/1436378/
[2] https://lore.kernel.org/patchwork/cover/1436375/

---
Best Regards, Laurentiu

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-07 12:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-07  3:53 [PATCH -next] bus/fsl-mc: fix doc warning ChenXiaoSong
2021-06-07 12:17 ` Laurentiu Tudor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).