From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Build failures since 5.4-rc3
Date: Tue, 15 Oct 2019 12:32:07 -0700 [thread overview]
Message-ID: <44f9a9bde7cf7885a8e55a52260b59240cb9a157.camel@perches.com> (raw)
In-Reply-To: <2da85bba-ab2a-b993-be1a-c98222819b37@lwfinger.net>
On Tue, 2019-10-15 at 14:09 -0500, Larry Finger wrote:
> Joe,
Hey Larry.
> Since commit 294f69e662d1("compiler_attributes.h: Add 'fallthrough' pseudo
> keyword for switch/case use"), builds of VirtualBox are failing with the
> following errors:
>
> 1954s] In file included from
> /usr/src/linux-5.4.0-rc3-1.g2309d7d/include/linux/compiler_types.h:59,
> [ 1954s] from <command-line>:
> [ 1954s]
> /home/abuild/rpmbuild/BUILD/VirtualBox-6.0.12/modules_build_dir/default/vboxdrv/SUPDrvGip.c:
> In function 'supdrvTscDeltaThread':
> [ 1954s]
> /usr/src/linux-5.4.0-rc3-1.g2309d7d/include/linux/compiler_attributes.h:200:41:
> error: expected ')' before '__attribute__'
> [ 1954s] 200 | # define fallthrough
> __attribute__((__fallthrough__))
> [ 1954s] | ^~~~~~~~~~~~~
> [ 1954s]
> /home/abuild/rpmbuild/BUILD/VirtualBox-6.0.12/modules_build_dir/default/vboxdrv/include/iprt/cdefs.h:1169:44:
> note: in expansion of macro 'fallthrough'
> [ 1954s] 1169 | # define FALL_THROUGH __attribute__ ((fallthrough))
Looks like this should be:
#define FALL_THROUGH __attribute__((__fallthrough__))
and there appear to be many of these #defines that
use __attribute__((foo)) where foo does not use the
double underscored prefix and suffix form
I also downloaded and trivially attempted to build vbox
without success, but I don't find this #define anywhere
in the sources. Clues?
$ git clone git://github.com/mirror/vbox.git
$ cd vbox
$ git grep FALL_THROUGH
$
$ ./configure
Checking for environment: Determined build machine: linux.amd64, target machine: linux.amd64, OK.
Checking for kBuild:
** kmk (variable KBUILDDIR) not found!
Check /home/joe/vbox/configure.log for details
$ cat configure.log
# Log file generated by
#
# './configure '
#
***** Checking environment *****
Determined build machine: linux.amd64, target machine: linux.amd64
***** Checking kBuild *****
** kmk (variable KBUILDDIR) not found!
$
next prev parent reply other threads:[~2019-10-15 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 19:09 Build failures since 5.4-rc3 Larry Finger
2019-10-15 19:32 ` Joe Perches [this message]
2019-10-15 20:27 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44f9a9bde7cf7885a8e55a52260b59240cb9a157.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).