From: Geoff Levand <geoff@infradead.org>
To: YueHaibing <yuehaibing@huawei.com>,
davem@davemloft.net, benh@kernel.crashing.org, paulus@samba.org,
mpe@ellerman.id.au, kou.ishizaki@toshiba.co.jp, andrew@lunn.ch,
f.fainelli@gmail.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH net-next] net: toshiba: fix return type of ndo_start_xmit function
Date: Wed, 19 Sep 2018 09:10:46 -0700 [thread overview]
Message-ID: <44f9d0cf-e842-696a-2e49-e16643ea668e@infradead.org> (raw)
In-Reply-To: <20180919102339.13988-1-yuehaibing@huawei.com>
Hi Yue,
On 09/19/2018 03:23 AM, YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
>
> Found by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
I tested this against Linux-4.19-rc4, and it seemed to work OK.
Please remove the irrelevant line 'Found by coccinelle.' from the
commit message. With that change:
Acked-by: Geoff Levand <geoff@infradead.org>
-Geoff
next prev parent reply other threads:[~2018-09-19 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 10:23 [PATCH net-next] net: toshiba: fix return type of ndo_start_xmit function YueHaibing
2018-09-19 16:10 ` Geoff Levand [this message]
2018-09-20 4:19 ` David Miller
2018-09-19 10:32 YueHaibing
2018-09-19 10:35 ` YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44f9d0cf-e842-696a-2e49-e16643ea668e@infradead.org \
--to=geoff@infradead.org \
--cc=andrew@lunn.ch \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).