From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753463AbbCJWjf (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Mar 2015 18:39:35 -0400
Received: from mout.kundenserver.de ([212.227.17.24]:54444 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751844AbbCJWjb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Mar 2015 18:39:31 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Ray Jui <rjui@broadcom.com>, Bjorn Helgaas <bhelgaas@google.com>,
        devicetree@vger.kernel.org, Paul Bolle <pebolle@tiscali.nl>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Scott Branden <sbranden@broadcom.com>, Rob Herring <robh@kernel.org>,
        Hauke Mehrtens <hauke@hauke-m.de>, linux-kernel@vger.kernel.org,
        Anatol Pomazau <anatol@google.com>, linux-pci@vger.kernel.org,
        Yijing Wang <wangyijing@huawei.com>,
        bcm-kernel-feedback-list@broadcom.com,
        Dmitry Torokhov <dtor@google.com>
Subject: Re: [PATCH v5 3/4] pci: iproc: Add Broadcom iProc PCIe support
Date: Tue, 10 Mar 2015 23:39:08 +0100
Message-ID: <4502186.8jmIz85sZB@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <54FF6EAC.90603@broadcom.com>
References: <1425947886-23705-1-git-send-email-rjui@broadcom.com> <20150310214010.GB32204@google.com> <54FF6EAC.90603@broadcom.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:yVBQRb+skIASSKW9cGys2LdpQzrqUVTD0nJ4GQ8q9TVsNLCbPYX
 /iNKldr2qwKWr0rUgEIMcMnxg3ZFG62y1ph+HCxE1+itnQhX0Sqc8TzbATFnXFVA9+jnorV
 0JRH6WDntUpaxnoTaILOx/hS2z/wdF5Eu0+/8hR+r7bWZvulBeMSLjvTXCsgQEif5Wooobx
 BCtFR54Xwwo/n5g+3T3KQ==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 10 March 2015 15:22:36 Ray Jui wrote:
> > Do you anticipate additional front-end bus interfaces?  If not, and maybe
> > even if you do, you might squash everything into pcie-iproc.c.  Then you
> > only need one file (no .h file needed) and the package is a little
> > simpler.  I think it's pretty common to have multiple driver registration
> > methods in the same file (OF, PCI, ACPI, etc.)  And I think it's common to
> > have those methods guarded by the generic config symbol (CONFIG_PCI,
> > CONFIG_OF, etc.) rather than defining new ones specific to the driver.
> > 
> 
> Yes I do expect Hauke (CCed) to add BCMA bus front end support later.
> 
> I still think having the front end bus driver separated is cleaner and
> may be less troublesome for Hauke to add BCMA support in the future. But
> if you strongly favor having everything stuffed in one single file, I
> can make that change. Please let me know.
> 

I was the one that initially suggested splitting the driver into files
like this, and I still think it's the right strategy with the
BCMA driver coming up.

	Arnd