From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com,
yung-chuan.liao@linux.intel.com
Subject: Re: [PATCH] soundwire: debugfs: use controller id instead of link_id
Date: Tue, 19 Jan 2021 09:54:17 -0600 [thread overview]
Message-ID: <45300dc3-00b0-497b-804e-f7f1e857f32a@linux.intel.com> (raw)
In-Reply-To: <20210119145220.GS2771@vkoul-mobl>
On 1/19/21 8:52 AM, Vinod Koul wrote:
> On 15-01-21, 16:25, Srinivas Kandagatla wrote:
>> link_id can be zero and if we have multiple controller instances
>> in a system like Qualcomm debugfs will end-up with duplicate namespace
>> resulting in incorrect debugfs entries.
>>
>> Using id should give a unique debugfs directory entry and should fix below
>> warning too.
>> "debugfs: Directory 'master-0' with parent 'soundwire' already present!"
>
> Yeah id is guaranteed to be unique so this will work.
>
> Applied, thanks
This patch is a no-op for Intel, but I am not convinced it's the right
fix or the definitions are not consistent.
* @link_id: Link id number, can be 0 to N, unique for each Master
* @id: bus system-wide unique id
In the MIPI/DisCo definitions, a controller can have multiple masters.
if you have multiple controllers, each of them should have their own
debugfs directory IMHO. It's totally fine to have multiple bus/masters
with a link_id == 0.
next prev parent reply other threads:[~2021-01-19 16:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 16:25 [PATCH] soundwire: debugfs: use controller id instead of link_id Srinivas Kandagatla
2021-01-19 14:52 ` Vinod Koul
2021-01-19 15:54 ` Pierre-Louis Bossart [this message]
2021-01-19 17:17 ` Srinivas Kandagatla
2021-01-19 19:09 ` Pierre-Louis Bossart
2021-01-21 12:03 ` Srinivas Kandagatla
2021-01-21 15:12 ` Pierre-Louis Bossart
2021-01-21 17:23 ` Srinivas Kandagatla
2021-01-21 18:22 ` Pierre-Louis Bossart
2021-02-01 10:14 ` Vinod Koul
2021-02-01 16:10 ` Pierre-Louis Bossart
2021-02-02 4:18 ` Vinod Koul
2021-02-02 16:43 ` Pierre-Louis Bossart
2021-02-03 11:14 ` Vinod Koul
2021-02-06 10:22 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45300dc3-00b0-497b-804e-f7f1e857f32a@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).