Hi Luis, >> --- >> commit id 'kallsyms: print module name in %ps/S case when KALLSYMS is disabled' >> needs to be removed from mm(linux-next) tree, current change is >> with ignorance of this commit. I was not sure how to send patch, with 2 patches >> consisting reversal commit also, or current approach is correct. >> >> v1->v2: hash base address of module, change *fmt to fmt[0] and removed >> copy paste. >> v2->v3: fixed review comments from Andy Shevchenko >> >> include/linux/kallsyms.h | 2 + >> include/linux/module.h | 20 ++++++++++ >> kernel/kallsyms.c | 27 +++++++------ >> kernel/module.c | 4 +- >> lib/vsprintf.c | 85 ++++++++++++++++++++++++++++++++++------ > > Hey Maninder, thanks for your patch! > > Since this touches kernel/module.c and include/linux/module.h I'd prefer > this go through modules-next [0], and as you will see that's a different > world right now. I also have a set of at least 2 other patch sets to > merge there before yours. > > Also, what is on modules-next is not intended to go to Linus for the > next merge window as the changes there got merged only late, and I want > at least 2 months of testing on linux-newt before any pull requiest is > sent to Linus. > > Can you rebase to modules-next? I can evaluate the patches then for > integration there once the other stuff gets merged into that tree too. > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=modules-next > > Luis prepared and verified patch(KALLSYMS enabled and disabled both) on module-next rebase and sent in new mail. [PATCH 1/1 module-next] kallsyms: enhance %pS/s/b printing when KALLSYSMS is disabled https://lkml.org/lkml/2022/3/16/7 Thanks, Maninder Singh