From: Aleksa Savic <savicaleksa83@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: savicaleksa83@gmail.com, Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: Add driver for Gigabyte AORUS Waterforce AIO coolers
Date: Sat, 2 Dec 2023 16:01:16 +0100 [thread overview]
Message-ID: <45484650-4975-4f66-971d-7599681b1538@gmail.com> (raw)
In-Reply-To: <20231020130212.8919-1-savicaleksa83@gmail.com>
On 2023-10-20 15:02:08 GMT+02:00, Aleksa Savic wrote:
> This driver exposes hardware sensors of the Gigabyte AORUS Waterforce
> all-in-one CPU liquid coolers, which communicate through a proprietary
> USB HID protocol. Report offsets were initially discovered in [1] and
> confirmed by me on a Waterforce X240 by observing the sent reports from
> the official software.
>
> Available sensors are pump and fan speed in RPM, as well as coolant
> temperature. Also available through debugfs is the firmware version.
>
> Attaching a fan is optional and allows it to be controlled from the
> device. If it's not connected, the fan-related sensors will report
> zeroes.
>
> The addressable RGB LEDs and LCD screen are not supported in this
> driver and should be controlled through userspace tools.
>
> [1]: https://github.com/liquidctl/liquidctl/issues/167
>
> Signed-off-by: Aleksa Savic <savicaleksa83@gmail.com>
> ---
> Documentation/hwmon/gigabyte_waterforce.rst | 47 +++
> MAINTAINERS | 7 +
> drivers/hwmon/Kconfig | 10 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/gigabyte_waterforce.c | 439 ++++++++++++++++++++
> 5 files changed, 504 insertions(+)
> create mode 100644 Documentation/hwmon/gigabyte_waterforce.rst
> create mode 100644 drivers/hwmon/gigabyte_waterforce.c
Hi Guenter,
Any thoughts on the patch? I'll fix the issues kernel bot reported
in v2.
Thanks,
Aleksa
next prev parent reply other threads:[~2023-12-02 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 13:02 [PATCH] hwmon: Add driver for Gigabyte AORUS Waterforce AIO coolers Aleksa Savic
2023-10-27 9:42 ` kernel test robot
2023-10-30 2:06 ` kernel test robot
2023-12-02 15:01 ` Aleksa Savic [this message]
2023-12-02 15:42 ` Guenter Roeck
2023-12-02 16:02 ` Aleksa Savic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45484650-4975-4f66-971d-7599681b1538@gmail.com \
--to=savicaleksa83@gmail.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).