From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030232AbdADNYL convert rfc822-to-8bit (ORCPT ); Wed, 4 Jan 2017 08:24:11 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:55005 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967690AbdADNX5 (ORCPT ); Wed, 4 Jan 2017 08:23:57 -0500 From: Arnd Bergmann To: Greentime Hu Cc: Florian Fainelli , netdev , devicetree@vger.kernel.org, Andrew Lunn , linux-kernel@vger.kernel.org, Jiri Pirko , jonas.jensen@gmail.com, davem@davemloft.net Subject: Re: [PATCH v3] net: ethernet: faraday: To support device tree usage. Date: Wed, 04 Jan 2017 14:23:15 +0100 Message-ID: <4553002.lqp6KanHTq@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1483083470-15779-1-git-send-email-green.hu@gmail.com> <2299808.LHnPolcyRJ@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:CsRrll9TuMIwKDMuYjb6EuIQx3BldI5o2la8ALs3GiNWGLGL4cs zFZFefbE/4OyGW7xjHIfiU6bZWk+hTOvmewaeH6GUVWil8R1+MULp1SSNjY3VzoRxqPcgFf HtYRgZyWw4Z4/7GgrukRmQJyOrT7RTXd/BMkT1kDjaOb2uGIeKfPWI9TSZ06ZEgMnZ3qvCB RwANzfvC7zYJLhGKTdlVw== X-UI-Out-Filterresults: notjunk:1;V01:K0:z08glrU1QaY=:V1LCALZ1RHH8/2lQ8LmuRT wBOjdOswgew5Oo3O2wfdwTOz4swd0dq8jJqRDOIpF4FMtDdBNtR3t2vDQ5P8spJQG8a4SYzYB 58UdaYJp98mbdZbdzeuly04kTlBTj9QiQ+/oiUPBEgoX9Q0CPZmBy+CWWjQP6Taa9num737BK wfWvg+KB7rlZJby+tJ1+Q1jxViQpgw+UnBQArVJDCuFqTEKJj7C9619a8xk9CEP3eRWOSOtDK BOoziH3qviqJImhpwTHEBfJPZkB48B9reRijuojbsjcvz3iPyG2hsFfohq646iCC1g6P0hX14 +h8wZTLJAWsJMmE+XxameBAhNcQENT5Uqy5XH3Q2QEKiUcKR0sJaXmTIAFjXY3S8QBLg9tVqq O5KRePDL534W9XNUYWVNEAC741F59fQuFcJKrz5dsg6XLSlEif6Iu7ufaDSPaISXAgGqVdMIv AdQIivyhX/bNv6hlmU0C+5sHuowGahskP3JSA4XCIBgpUJxbjDBGbh3bMDdELkl0UHYhE73lG rxAhi4tfGy/07zpQMd8i+dAr88qTfSfEK3h6IpDvYCjVsOxzQXLV1XhzjJSmk4MW+3PKAK/j8 J29ctB9fUcDS7ZVX1XfnqPXm55AzPdcz4iFhEWALYoX/OCDsz0+Y8/xfLzxKg6JIlISjka2If CI4G5pRsASCr5OA5pJT0T8hrMNZBJIxWBL8wPz3zZw1FOKXZ8dGmk1xChicfB3tuYFiAm0w0V Ht3mDXYCcSbM7C3+ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, January 4, 2017 9:49:51 AM CET Greentime Hu wrote: > On Tue, Jan 3, 2017 at 9:24 PM, Arnd Bergmann wrote: > > > On Tuesday, January 3, 2017 2:05:47 PM CET Greentime Hu wrote: > > > ​I am not sure if atmac and moxa-art are exactly hardware compatible > > though > > > they are based on faraday ftmac. > > > It may be better if we use 2 different device tree binding documents to > > > describe for these 2 different drivers to use. > > > > They are probably slightly different, but close enough to have the same > > binding document, as there is no technical reason to have two separate > > drivers for them. The binding should be about the hardware type, not the > > way that Linux currently implements the drivers. > > > > Arnd > > > > > OK. > > How about this? > > rename > Documentation/devicetree/bindings/net/moxa,moxart-mac.txt > to > Documentation/devicetree/bindings/net/faraday,ftmac.txt > > and the content to > Faraday Ethernet Controller Sounds good. Note that you can use 'git patch -M' to produce this as a renaming patch. > > Required properties: > > - compatible : Must be "moxa,moxart-mac" or "andestech,atmac" or > "faraday,ftmac" I'd write this as compatible: Must contain "faraday,ftmac", as well as one of the SoC specific identifiers: "andestec,atmac" "moxa,moxart-mac" This makes it easier to extend, plus it makes the generic string mandatory. Arnd