From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 601F6C433FE for ; Sat, 9 Apr 2022 11:01:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241472AbiDILDo (ORCPT ); Sat, 9 Apr 2022 07:03:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231465AbiDILDn (ORCPT ); Sat, 9 Apr 2022 07:03:43 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75DD0139271; Sat, 9 Apr 2022 04:01:34 -0700 (PDT) Received: from p508fd313.dip0.t-ipconnect.de ([80.143.211.19] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nd8qM-0000r9-FR; Sat, 09 Apr 2022 13:01:26 +0200 From: Heiko Stuebner To: Dan Johansen , Frank Wunderlich Cc: Frank Wunderlich , linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Peter Geis , Michael Riesch , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Aw: Re: Re: [PATCH] arm64: dts: rockchip: Fix clocks for rk356x usb Date: Sat, 09 Apr 2022 13:01:25 +0200 Message-ID: <4559790.iIbC2pHGDl@phil> In-Reply-To: References: <20220409075147.136187-1-linux@fw-web.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Samstag, 9. April 2022, 12:57:39 CEST schrieb Frank Wunderlich: > Hi > > Gesendet: Samstag, 09. April 2022 um 12:40 Uhr > > Von: "Dan Johansen" > > > So the issue is only with usb 3 ports, not usb 2 ports? > > my board has no standalone usb2-ports. usb2 is integrated into the usb3 ports (dual phy). here both were not working. > > afaik rk3566 has standalone usb2 ports that may not be broken, but i have no such board for testing. As far as I understand the issue now after checking the code, this patch actually fixes the usb3 series from Peter, right? I.e. the usb-nodes that are fixed in this patch are not yet present in the main rk356x dtsi and only get added in "arm64: dts: rockchip: add rk356x dwc3 usb3 nodes" [0] As we don't want to add broken changes, this fix should squashed into a next version of the patch adding the nodes. Heiko [0] https://lore.kernel.org/r/20220408151237.3165046-4-pgwipeout@gmail.com