From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A2E4C3A5A1 for ; Wed, 28 Aug 2019 16:44:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34B7E208CB for ; Wed, 28 Aug 2019 16:44:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726990AbfH1Qo4 (ORCPT ); Wed, 28 Aug 2019 12:44:56 -0400 Received: from baldur.buserror.net ([165.227.176.147]:50714 "EHLO baldur.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726400AbfH1Qoz (ORCPT ); Wed, 28 Aug 2019 12:44:55 -0400 Received: from [2601:449:8400:7293:12bf:48ff:fe84:c9a0] by baldur.buserror.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i313y-0002t0-PH; Wed, 28 Aug 2019 11:44:51 -0500 Message-ID: <457508f39b96caab15ed4bf7ff0d586ffdc850f8.camel@buserror.net> From: Scott Wood To: Jason Yan Cc: wangkefeng.wang@huawei.com, keescook@chromium.org, kernel-hardening@lists.openwall.com, thunder.leizhen@huawei.com, linux-kernel@vger.kernel.org, npiggin@gmail.com, jingxiangfeng@huawei.com, diana.craciun@nxp.com, paulus@samba.org, zhaohongjiang@huawei.com, fanchengyang@huawei.com, linuxppc-dev@lists.ozlabs.org, yebin10@huawei.com Date: Wed, 28 Aug 2019 11:44:48 -0500 In-Reply-To: References: <20190809100800.5426-1-yanaijie@huawei.com> <20190809100800.5426-7-yanaijie@huawei.com> <20190828045454.GB17757@home.buserror.net> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2601:449:8400:7293:12bf:48ff:fe84:c9a0 X-SA-Exim-Rcpt-To: yanaijie@huawei.com, wangkefeng.wang@huawei.com, keescook@chromium.org, kernel-hardening@lists.openwall.com, thunder.leizhen@huawei.com, linux-kernel@vger.kernel.org, npiggin@gmail.com, jingxiangfeng@huawei.com, diana.craciun@nxp.com, paulus@samba.org, zhaohongjiang@huawei.com, fanchengyang@huawei.com, linuxppc-dev@lists.ozlabs.org, yebin10@huawei.com X-SA-Exim-Mail-From: oss@buserror.net Subject: Re: [PATCH v6 06/12] powerpc/fsl_booke/32: implement KASLR infrastructure X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on baldur.buserror.net) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-08-28 at 19:03 +0800, Jason Yan wrote: > > On 2019/8/28 12:54, Scott Wood wrote: > > On Fri, Aug 09, 2019 at 06:07:54PM +0800, Jason Yan wrote: > > > +/* > > > + * To see if we need to relocate the kernel to a random offset > > > + * void *dt_ptr - address of the device tree > > > + * phys_addr_t size - size of the first memory block > > > + */ > > > +notrace void __init kaslr_early_init(void *dt_ptr, phys_addr_t size) > > > +{ > > > + unsigned long tlb_virt; > > > + phys_addr_t tlb_phys; > > > + unsigned long offset; > > > + unsigned long kernel_sz; > > > + > > > + kernel_sz = (unsigned long)_end - KERNELBASE; > > > > Why KERNELBASE and not kernstart_addr? > > > > Did you mean kernstart_virt_addr? It should be kernstart_virt_addr. Yes, kernstart_virt_addr. KERNELBASE will be incorrect if the kernel was loaded at a nonzero physical address without CONFIG_PHYSICAL_START being adjusted to match. -Scott