From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756626AbcBQGpb (ORCPT ); Wed, 17 Feb 2016 01:45:31 -0500 Received: from gloria.sntech.de ([95.129.55.99]:60333 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756478AbcBQGp2 convert rfc822-to-8bit (ORCPT ); Wed, 17 Feb 2016 01:45:28 -0500 From: Heiko Stuebner To: Jianqun Xu Cc: Mark Brown , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, jwerner@chromium.org, huangtao@rock-chips.com, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH] spi/rockchip: Add dt-binding for Rockchip rk3399 spi Date: Wed, 17 Feb 2016 07:45:09 +0100 Message-ID: <4579617.rz6Yi2sU5M@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <56C3BD26.3030704@rock-chips.com> References: <1455614538-4415-1-git-send-email-jay.xu@rock-chips.com> <1730751.NYv1NxJVuB@phil> <56C3BD26.3030704@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jianqun, Am Mittwoch, 17. Februar 2016, 08:21:58 schrieb Jianqun Xu: > 在 16/02/2016 22:37, Heiko Stuebner 写道: > > Am Dienstag, 16. Februar 2016, 13:22:23 schrieb Mark Brown: > >> On Tue, Feb 16, 2016 at 05:22:18PM +0800, jianqun.xu wrote: > >>> Documentation/devicetree/bindings/spi/spi-rockchip.txt | 1 + > >>> 1 file changed, 1 insertion(+) > >> > >> I'd expect this to be added to both the driver and the binding document > >> not just the document. > > > > It seems the driver can still use the rk3066-variant - aka nobody has > > found specific issues in the rk3399 IP implementation. > > > > Having the more specific IP names already in the dts before actually > > using them was suggested by devicetree people to not have to exchange > > everything once specific issues were found. > > > > So right now it's using the fallback-mechanism of binding to the rk3066 > > name, but if some obstacle appears it will only take adding the binding > > in the driver to make it work (even with old devicetrees). > > Thank you, got it, and I will re-send this patch with the driver patch. you have me confused now :-) . That was meant as a reply to Mark's comment, explaining why the double compatible and the driver only binding to the rk3066-one right now. Heiko