From: Sven Eckelmann <sven@narfation.org>
To: linux-kernel@vger.kernel.org, "Enrico Weigelt,
metux IT consult" <info@metux.net>
Cc: davem@davemloft.net, kuba@kernel.org, mareklindner@neomailbox.ch,
sw@simonwunderlich.de, a@unstable.cc, marcel@holtmann.org,
johan.hedberg@gmail.com, roopa@nvidia.com, nikolay@nvidia.com,
edumazet@google.com, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, jmaloy@redhat.com,
ying.xue@windriver.com, kafai@fb.com, songliubraving@fb.com,
yhs@fb.com, john.fastabend@gmail.com, kpsingh@chromium.org,
netdev@vger.kernel.org, linux-bluetooth@vger.kernel.org,
tipc-discussion@lists.sourceforge.net,
linux-hyperv@vger.kernel.org, bpf@vger.kernel.org,
Matthias Schiffer <mschiffer@universe-factory.net>
Subject: Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage
Date: Sat, 05 Dec 2020 08:06:40 +0100 [thread overview]
Message-ID: <4581108.GXAFRqVoOG@sven-edge> (raw)
In-Reply-To: <20201202124959.29209-2-info@metux.net>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
On Wednesday, 2 December 2020 13:49:54 CET Enrico Weigelt, metux IT consult wrote:
> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
Is there some explanation besides an opinion? Some kind goal which you want to
achieve with it maybe?
At least for us it was an easy way to query the release cycle information via
batctl. Which made it easier for us to roughly figure out what an reporter/
inquirer was using - independent of whether he is using the in-kernel version
or a backported version.
Loosing this source of information and breaking parts of batctl and other
tools (respondd, ...) is not the end of the world. But I would at least know
why this is now necessary.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-05 7:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 12:49 [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage Enrico Weigelt, metux IT consult
2020-12-02 12:49 ` [PATCH 2/7] net: batman-adv: " Enrico Weigelt, metux IT consult
2020-12-05 7:06 ` Sven Eckelmann [this message]
2020-12-05 16:56 ` Jakub Kicinski
2020-12-08 7:48 ` Enrico Weigelt, metux IT consult
2020-12-08 9:55 ` Sven Eckelmann
2020-12-02 12:49 ` [PATCH 3/7] net: ipv4: " Enrico Weigelt, metux IT consult
2020-12-02 12:49 ` [PATCH 4/7] net: bluetooth: " Enrico Weigelt, metux IT consult
2020-12-02 12:49 ` [PATCH 5/7] net: bridge: " Enrico Weigelt, metux IT consult
2020-12-02 12:49 ` [PATCH 6/7] net: vmw_vsock: " Enrico Weigelt, metux IT consult
2020-12-02 12:49 ` [PATCH 7/7] net: tipc: " Enrico Weigelt, metux IT consult
2020-12-05 0:09 ` [PATCH 1/7] net: 8021q: " Jakub Kicinski
2020-12-05 10:51 ` Joe Perches
2020-12-05 11:20 ` Vladimir Oltean
2020-12-05 15:53 ` Greg KH
2020-12-08 8:51 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4581108.GXAFRqVoOG@sven-edge \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=info@metux.net \
--cc=jmaloy@redhat.com \
--cc=johan.hedberg@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mareklindner@neomailbox.ch \
--cc=mschiffer@universe-factory.net \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
--cc=songliubraving@fb.com \
--cc=sw@simonwunderlich.de \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=yhs@fb.com \
--cc=ying.xue@windriver.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).