From: Dan Murphy <dmurphy@ti.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <andrew@lunn.ch>, <f.fainelli@gmail.com>, <hkallweit1@gmail.com>,
<davem@davemloft.net>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps
Date: Tue, 19 May 2020 12:56:40 -0500 [thread overview]
Message-ID: <459afc6f-a519-43f5-aeb2-e28c362237b3@ti.com> (raw)
In-Reply-To: <65e1b5ca-680e-f82d-cde4-3d5a3eb40884@ti.com>
Jakub
On 5/19/20 12:40 PM, Dan Murphy wrote:
> Jakub
>
> On 5/19/20 11:58 AM, Jakub Kicinski wrote:
>> On Tue, 19 May 2020 09:18:11 -0500 Dan Murphy wrote:
>>> If the op-mode for the device is not set in the device tree then set
>>> the strapped op-mode and store it for later configuration.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ../drivers/net/phy/dp83869.c: In function0 dp83869_set_strapped_mode:
>> ../drivers/net/phy/dp83869.c:171:10: warning: comparison is always
>> false due to limited range of data type [-Wtype-limits]
>> 171 | if (val < 0)
>> | ^
>
> This looks to be a false positive.
>
> phy_read_mmd will return an errno or a value from 0->15
>
> So if errno is returned then this will be true.
>
> Unless I have to do IS_ERR.
>
> I did not get that warning. But I am using 9.2-gcc.
>
> What compiler are you using?
>
I see what the issue is val needs to be an int not a u16
I will fix it
Dan
> Dan
>
next prev parent reply other threads:[~2020-05-19 17:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 14:18 [PATCH net-next 0/4] DP83869 Enhancements Dan Murphy
2020-05-19 14:18 ` [PATCH net-next 1/4] net: phy: dp83869: Update port-mirroring to read straps Dan Murphy
2020-05-19 20:03 ` Florian Fainelli
2020-05-19 14:18 ` [PATCH net-next 2/4] net: phy: dp83869: Set opmode from straps Dan Murphy
2020-05-19 16:58 ` Jakub Kicinski
2020-05-19 17:40 ` Dan Murphy
2020-05-19 17:56 ` Dan Murphy [this message]
2020-05-19 18:29 ` Andrew Lunn
2020-05-19 18:41 ` Dan Murphy
2020-05-19 18:48 ` Jakub Kicinski
2020-05-19 18:59 ` Dan Murphy
2020-05-19 19:03 ` Andrew Lunn
2020-05-19 17:19 ` kbuild test robot
2020-05-19 17:40 ` Dan Murphy
2020-05-19 23:54 ` [kbuild-all] " Philip Li
2020-05-19 19:16 ` kbuild test robot
2020-05-19 14:18 ` [PATCH net-next 3/4] dt-bindings: net: Add RGMII internal delay for DP83869 Dan Murphy
2020-05-19 14:18 ` [PATCH net-next 4/4] net: dp83869: Add RGMII internal delay configuration Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459afc6f-a519-43f5-aeb2-e28c362237b3@ti.com \
--to=dmurphy@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).