From: Jeff Garzik <jgarzik@pobox.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Alan <alan@lxorguk.ukuu.org.uk>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata-sff: Don't call bmdma_stop on non DMA capable controllers
Date: Thu, 25 Jan 2007 11:17:20 -0500 [thread overview]
Message-ID: <45B8D810.3030501@pobox.com> (raw)
In-Reply-To: <1169741658.3593.98.camel@shinybook.infradead.org>
David Woodhouse wrote:
> On Thu, 2007-01-25 at 15:09 +0000, Alan wrote:
>> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-rc4-mm1/drivers/ata/libata-sff.c linux-2.6.20-rc4-mm1/drivers/ata/libata-sff.c
>> --- linux.vanilla-2.6.20-rc4-mm1/drivers/ata/libata-sff.c 2007-01-22 16:26:50.000000000 +0000
>> +++ linux-2.6.20-rc4-mm1/drivers/ata/libata-sff.c 2007-01-24 17:31:40.000000000 +0000
>> @@ -827,7 +827,8 @@
>> */
>> void ata_bmdma_post_internal_cmd(struct ata_queued_cmd *qc)
>> {
>> - ata_bmdma_stop(qc);
>> + if (qc->ap->ioaddr.bmdma_addr)
>> + ata_bmdma_stop(qc);
>> }
>
> But what if the bmdma_addr _is_ zero? Please, let's not allow the "zero
> is not a valid number" braindamage to spread any further than the IRQ
> setup it's already broken.
Read the code... This test is already widely in use in libata.
Jeff
next prev parent reply other threads:[~2007-01-25 16:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 15:09 [PATCH] libata-sff: Don't call bmdma_stop on non DMA capable controllers Alan
2007-01-25 16:14 ` David Woodhouse
2007-01-25 16:17 ` Jeff Garzik [this message]
2007-01-25 16:19 ` David Woodhouse
2007-01-25 16:22 ` Russell King
2007-01-25 16:26 ` David Woodhouse
2007-01-25 17:27 ` Alan
2007-01-25 17:56 ` Linus Torvalds
2007-01-26 0:23 ` David Woodhouse
2007-01-26 1:28 ` Linus Torvalds
2007-01-26 1:45 ` Jeff Garzik
2007-01-26 2:01 ` Linus Torvalds
2007-01-26 2:11 ` Jeff Garzik
2007-01-26 10:37 ` Alan
2007-01-28 23:01 ` Benjamin Herrenschmidt
2007-01-28 22:57 ` Benjamin Herrenschmidt
2007-01-26 2:23 ` David Woodhouse
2007-01-26 2:58 ` Linus Torvalds
2007-01-26 3:28 ` David Woodhouse
2007-01-26 4:00 ` Linus Torvalds
2007-01-26 4:19 ` David Woodhouse
2007-01-26 4:48 ` Linus Torvalds
2007-01-26 5:09 ` David Woodhouse
2007-01-26 6:01 ` Linus Torvalds
2007-01-26 6:18 ` Linus Torvalds
2007-01-26 8:17 ` David Miller
2007-01-26 8:20 ` David Miller
2007-01-26 4:53 ` Jeff Garzik
2007-01-26 15:32 ` Mark Lord
2007-01-26 15:29 ` Mark Lord
2007-01-28 23:04 ` Benjamin Herrenschmidt
2007-01-28 22:49 ` Benjamin Herrenschmidt
2007-01-25 23:36 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B8D810.3030501@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).