From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750696AbXBKPtc (ORCPT ); Sun, 11 Feb 2007 10:49:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750703AbXBKPtc (ORCPT ); Sun, 11 Feb 2007 10:49:32 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:44758 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750696AbXBKPtb (ORCPT ); Sun, 11 Feb 2007 10:49:31 -0500 Message-ID: <45CF3AF6.2060203@garzik.org> Date: Sun, 11 Feb 2007 10:49:10 -0500 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.9 (X11/20070130) MIME-Version: 1.0 To: Al Viro CC: torvalds@linux-foundation.org, Tejun Heo , Christoph Hellwig , Andrew Morton , Martin Schwidefsky , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [PATCH] sort the devres mess out References: <20070210114550.GC12642@osiris.boeblingen.de.ibm.com> <20070211034902.GA9077@infradead.org> <45CEB720.1020406@gmail.com> <20070211063431.GS10050@ftp.linux.org.uk> <20070211153144.GA11547@osiris.ibm.com> <20070211154131.GW10050@ftp.linux.org.uk> In-Reply-To: <20070211154131.GW10050@ftp.linux.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.7 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Al Viro wrote: > * Split the implementation-agnostic stuff in separate files. > * Make sure that targets using non-default request_irq() pull > kernel/irq/devres.o > * Introduce new symbols (HAS_IOPORT and HAS_IOMEM) defaulting to positive; > allow architectures to turn them off (we needed these symbols anyway for > dependencies of quite a few drivers). > * protect the ioport-related parts of lib/devres.o with CONFIG_HAS_IOPORT. > > Signed-off-by: Al Viro > --- > arch/arm/Kconfig | 5 + > arch/cris/Kconfig | 3 + > arch/h8300/Kconfig | 3 + > arch/h8300/kernel/Makefile | 4 +- > arch/m32r/Kconfig | 3 + > arch/m68k/Kconfig | 3 + > arch/m68k/kernel/Makefile | 4 +- > arch/m68knommu/Kconfig | 3 + > arch/s390/Kconfig | 3 + > arch/sparc/kernel/Makefile | 4 +- > arch/um/Kconfig | 3 + > arch/xtensa/Kconfig | 3 + > include/linux/io.h | 6 - > include/linux/pci.h | 5 + > kernel/irq/Makefile | 2 +- > kernel/irq/devres.c | 88 +++++++++++++ > kernel/irq/manage.c | 86 ------------- > lib/Kconfig | 9 +- > lib/Makefile | 5 +- > lib/devres.c | 300 ++++++++++++++++++++++++++++++++++++++++++++ > lib/iomap.c | 296 ------------------------------------------- > 21 files changed, 442 insertions(+), 396 deletions(-) > create mode 100644 kernel/irq/devres.c > create mode 100644 lib/devres.c ACK