From: Tejun Heo <htejun@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Robert Hancock <hancockr@shaw.ca>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: pcim_enable_device BUGs for libata devices in 2.6.20-git6
Date: Tue, 13 Feb 2007 07:30:03 -0800 [thread overview]
Message-ID: <45D1D97B.6010002@gmail.com> (raw)
In-Reply-To: <20070212205444.GC18101@elf.ucw.cz>
Hello, Pavel.
Pavel Machek wrote:
>> 1. Don't restore power state and re-enable PCI device on resume from
>> freeze just as we don't do the opposite when freezing.
>>
>> 2. Unconditionally disable and power down PCI device on suspend whether
>> it's freeze or not.
>>
>> #2 would be simpler but I'm a bit worried about it. There might be
>> controllers which choke after such sequence (save state, disable, power
>> down, no actual power removal, power on, restore state, re-enable).
>
> I'd just go for #2.
I think I've been seeing too many weird ATA controller issues to be bold
about this. I'll chicken out and go for #1. :-)
>> #1 can be easily done by taking a look at the current device power state
>> (gendev->power.power_state). The problem is that no one in
>> suspend/resume path seems to be setting that variable except for
>> runtime
>
> No, that variable is probably going to go away. If you want to
> remember that you are resuming from freeze, just store that info in
> private data structure.
I see. Thanks.
--
tejun
prev parent reply other threads:[~2007-02-13 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 0:44 pcim_enable_device BUGs for libata devices in 2.6.20-git6 Robert Hancock
2007-02-12 9:11 ` Tejun Heo
2007-02-12 20:54 ` Pavel Machek
2007-02-13 15:30 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D1D97B.6010002@gmail.com \
--to=htejun@gmail.com \
--cc=hancockr@shaw.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).