From: Zachary Amsden <zach@vmware.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andi Kleen <ak@muc.de>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, virtualization@lists.osdl.org,
xen-devel@lists.xensource.com, Chris Wright <chrisw@sous-sol.org>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [patch 10/21] Xen-paravirt: Name: dont export paravirt_ops structure, do individual functions
Date: Tue, 13 Feb 2007 17:06:42 -0800 [thread overview]
Message-ID: <45D260A2.4010200@vmware.com> (raw)
In-Reply-To: <20070213221830.238235953@goop.org>
Jeremy Fitzhardinge wrote:
> Wrap the paravirt_ops members we want to export in wrapper functions.
> Since we binary-patch the critical ones, this doesn't make a speed
> impact.
>
> I moved drm_follow_page into the core, to avoid having to wrap the
> various pte ops. Unlining kernel_fpu_end and using that in the RAID6
> code would remove the need to export clts/read_cr0/write_cr0 too.
>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> Signed-off-by: Chris Wright <chrisw@sous-sol.org>
> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
>
> ===================================================================
> --- a/arch/i386/kernel/paravirt.c
> +++ b/arch/i386/kernel/paravirt.c
> @@ -596,6 +596,123 @@ static int __init print_banner(void)
> return 0;
> }
> core_initcall(print_banner);
> +
> +unsigned long paravirt_save_flags(void)
> +{
> + return paravirt_ops.save_fl();
> +}
> +EXPORT_SYMBOL(paravirt_save_flags);
> +
> +void paravirt_restore_flags(unsigned long flags)
> +{
> + paravirt_ops.restore_fl(flags);
> +}
> +EXPORT_SYMBOL(paravirt_restore_flags);
> +
> +void paravirt_irq_disable(void)
> +{
> + paravirt_ops.irq_disable();
> +}
> +EXPORT_SYMBOL(paravirt_irq_disable);
> +
> +void paravirt_irq_enable(void)
> +{
> + paravirt_ops.irq_enable();
> +}
> +EXPORT_SYMBOL(paravirt_irq_enable);
>
This turned out really hideous looking to me. Can't we split the struct
into GPL'd and non-GPL'd functions instead? We still have the same
granularity, and none of this function call to an indirect function call
nonsense.
Zach
next prev parent reply other threads:[~2007-02-14 1:06 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070213221729.772002682@goop.org>
[not found] ` <20070213221829.929261125@goop.org>
2007-02-13 22:39 ` [patch 06/21] Xen-paravirt: remove ctor for pgd cache Zachary Amsden
[not found] ` <20070213221830.466651996@goop.org>
2007-02-13 22:45 ` [patch 13/21] Xen-paravirt: Add nosegneg capability to the vsyscall page notes Zachary Amsden
2007-02-13 22:49 ` Jeremy Fitzhardinge
2007-02-13 22:54 ` Zachary Amsden
2007-02-13 23:13 ` Jeremy Fitzhardinge
2007-02-14 5:38 ` [Xen-devel] " Rusty Russell
[not found] ` <20070213221830.542511707@goop.org>
2007-02-13 22:53 ` [patch 14/21] Xen-paravirt: Add XEN config options and disable unsupported config options Dan Hecht
2007-02-13 23:29 ` Jeremy Fitzhardinge
2007-02-13 23:58 ` [Xen-devel] " Zachary Amsden
2007-02-13 23:58 ` Dan Hecht
[not found] ` <20070213221830.238235953@goop.org>
2007-02-14 1:06 ` Zachary Amsden [this message]
2007-02-14 1:16 ` [patch 10/21] Xen-paravirt: Name: dont export paravirt_ops structure, do individual functions Jeremy Fitzhardinge
2007-02-14 1:18 ` Zachary Amsden
2007-02-14 1:37 ` Jeremy Fitzhardinge
2007-02-14 1:43 ` Zachary Amsden
2007-02-14 1:44 ` Jeremy Fitzhardinge
2007-02-14 5:51 ` Rusty Russell
2007-02-14 19:36 ` Christoph Hellwig
[not found] ` <20070213221829.845132535@goop.org>
2007-02-14 1:23 ` [patch 05/21] Xen-paravirt: paravirt_ops: allocate a fixmap slot Dan Hecht
2007-02-14 1:36 ` Jeremy Fitzhardinge
2007-02-14 2:34 ` Dan Hecht
2007-02-14 8:43 ` Gerd Hoffmann
2007-02-14 8:37 ` [Xen-devel] " Jan Beulich
2007-02-14 9:15 ` Andi Kleen
[not found] ` <20070213221829.513618819@goop.org>
2007-02-14 9:24 ` [patch 02/21] Xen-paravirt: Handle a zero-sized VT console Gerd Hoffmann
[not found] ` <20070213221830.707197267@goop.org>
2007-02-13 23:54 ` [patch 16/21] Xen-paravirt: Add code into head.S to handle being booted by Xen Andi Kleen
2007-02-14 0:39 ` Jeremy Fitzhardinge
2007-02-14 8:56 ` [Xen-devel] " Jan Beulich
2007-02-14 18:53 ` Jeremy Fitzhardinge
2007-02-14 20:10 ` Eric W. Biederman
2007-02-14 20:41 ` Jeremy Fitzhardinge
2007-02-14 21:06 ` Eric W. Biederman
2007-02-15 0:13 ` Jeremy Fitzhardinge
2007-02-15 1:39 ` Eric W. Biederman
2007-02-15 1:52 ` Jeremy Fitzhardinge
2007-02-15 2:18 ` Eric W. Biederman
2007-02-15 2:23 ` Jeremy Fitzhardinge
2007-02-15 2:41 ` Eric W. Biederman
2007-02-14 20:33 ` Eric W. Biederman
2007-02-14 20:42 ` Jeremy Fitzhardinge
[not found] ` <20070213221831.150207238@goop.org>
2007-02-14 20:40 ` [patch 21/21] Xen-paravirt: Add the Xen virtual network device driver Eric W. Biederman
[not found] ` <20070213221830.619562494@goop.org>
2007-02-14 20:45 ` [patch 15/21] Xen-paravirt: Add Xen interface header files Eric W. Biederman
2007-02-15 0:10 ` Jeremy Fitzhardinge
2007-02-15 17:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D260A2.4010200@vmware.com \
--to=zach@vmware.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).