From: Jeff Garzik <jeff@garzik.org>
To: Mark Brown <broonie@sirena.org.uk>
Cc: Tim Hockin <thockin@hockin.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] natsemi: Support Aculab E1/T1 PMXc cPCI carrier cards
Date: Sat, 17 Feb 2007 15:22:30 -0500 [thread overview]
Message-ID: <45D76406.1060002@garzik.org> (raw)
In-Reply-To: <20070214100227.222896000@sirena.org.uk>
Mark Brown wrote:
> Aculab E1/T1 PMXc cPCI carrier card cards present a natsemi on the cPCI
> bus with an oversized EEPROM using a direct MII<->MII connection with no
> PHY. This patch adds a new device table entry supporting these cards.
>
> Signed-Off-By: Mark Brown <broonie@sirena.org.uk>
> @@ -811,7 +816,11 @@
> np->hands_off = 0;
> np->intr_status = 0;
> np->eeprom_size = natsemi_pci_info[chip_idx].eeprom_size;
> - np->ignore_phy = 0;
> + if (natsemi_pci_info[chip_idx].flags & NATSEMI_FLAG_IGNORE_PHY) {
> + np->ignore_phy = 1;
> + } else {
> + np->ignore_phy = 0;
> + }
I ACK the patch itself, but since you have to resend anyway, please kill
the braces surrounding the above single-C-stmt lines.
next prev parent reply other threads:[~2007-02-17 20:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-14 10:02 [patch 0/2] natsemi: Support Aculab E1/T1 cPCI carrier cards Mark Brown
2007-02-14 10:02 ` [patch 1/2] natsemi: Add support for using MII port with no PHY Mark Brown
2007-02-14 13:28 ` Ahmed S. Darwish
2007-02-17 20:21 ` Jeff Garzik
2007-02-14 10:02 ` [patch 2/2] natsemi: Support Aculab E1/T1 PMXc cPCI carrier cards Mark Brown
2007-02-17 20:22 ` Jeff Garzik [this message]
2007-02-19 20:15 [patch 0/2] natsemi: Support Aculab E1/T1 " Mark Brown
2007-02-19 20:15 ` [patch 2/2] natsemi: Support Aculab E1/T1 PMXc " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D76406.1060002@garzik.org \
--to=jeff@garzik.org \
--cc=broonie@sirena.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=thockin@hockin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).