From: Qian Cai <cai@lca.pw>
To: paulmck@kernel.org
Cc: Will Deacon <will@kernel.org>, Elver Marco <elver@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: [PATCH -next v2] locking/osq_lock: annotate a data race in osq_lock
Date: Sat, 9 May 2020 12:53:38 -0400 [thread overview]
Message-ID: <45D9EEEB-D887-485D-9045-417A7F2C6A1A@lca.pw> (raw)
In-Reply-To: <20200509161217.GN2869@paulmck-ThinkPad-P72>
> On May 9, 2020, at 12:12 PM, Paul E. McKenney <paulmck@kernel.org> wrote:
>
> Ah, and I forgot to ask. Why "if (data_race(prev->next == node)" instead
> of "if (data_race(prev->next) == node"?
I think the one you suggested is slightly better to point out the exact race. Do you want me to resend or you could squash it instead?
next prev parent reply other threads:[~2020-05-09 16:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 13:54 [PATCH -next v2] locking/osq_lock: annotate a data race in osq_lock Qian Cai
2020-05-08 20:59 ` Qian Cai
2020-05-09 4:33 ` Paul E. McKenney
2020-05-09 13:01 ` Qian Cai
2020-05-09 16:12 ` Paul E. McKenney
2020-05-09 16:53 ` Qian Cai [this message]
2020-05-09 21:36 ` Paul E. McKenney
2020-05-11 15:58 ` Will Deacon
2020-05-11 16:43 ` Paul E. McKenney
2020-05-11 16:52 ` Will Deacon
2020-05-11 17:29 ` Paul E. McKenney
2020-05-11 17:34 ` Will Deacon
2020-05-11 18:07 ` Paul E. McKenney
2020-05-11 16:44 ` Qian Cai
2020-05-11 16:54 ` Will Deacon
2020-05-11 17:10 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D9EEEB-D887-485D-9045-417A7F2C6A1A@lca.pw \
--to=cai@lca.pw \
--cc=elver@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).