From: Tejun Heo <htejun@gmail.com>
To: Soeren Sonnenburg <kernel@nn7.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Adrian Bunk <bunk@stusta.de>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
Emil Karlson <jkarlson@cc.hut.fi>,
"Michael S. Tsirkin" <mst@mellanox.co.il>,
Len Brown <lenb@kernel.org>
Subject: Re: s2ram still broken with CONFIG_NO_HZ / HPET (macbook pro)
Date: Mon, 12 Mar 2007 19:59:14 +0900 [thread overview]
Message-ID: <45F53282.5040504@gmail.com> (raw)
In-Reply-To: <1173645941.4204.5.camel@localhost>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
Soeren Sonnenburg wrote:
> Elsewise I still see the
>
> ATA: abnormal status 0x80 on port 0x000140df
> ATA: abnormal status 0x80 on port 0x000140df
> ata1.00: configured for UDMA/33
> ata3.01: revalidation failed (errno=-2)
> ata3: failed to recover some devices, retrying in 5 secs
> ATA: abnormal status 0x7F on port 0x000140df
> ATA: abnormal status 0x7F on port 0x000140df
> ata3.01: configured for UDMA/133
I can't tell much about HPET timer, only the ATA messages.
Abnormal messages can be ignored. Hmmm... revalidation failed without
explaining why. Can you apply the attached patch and see whether the
added message gets printed?
--
tejun
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 551 bytes --]
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 14629a3..50a7954 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -1484,8 +1484,8 @@ int ata_dev_read_id(struct ata_device *dev, unsigned int *p_class,
id, sizeof(id[0]) * ATA_ID_WORDS);
if (err_mask) {
if (err_mask & AC_ERR_NODEV_HINT) {
- DPRINTK("ata%u.%d: NODEV after polling detection\n",
- ap->print_id, dev->devno);
+ ata_dev_printk(dev, KERN_INFO,
+ "NODEV after polling detection\n");
return -ENOENT;
}
next prev parent reply other threads:[~2007-03-12 10:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-11 20:45 s2ram still broken with CONFIG_NO_HZ / HPET (macbook pro) Soeren Sonnenburg
2007-03-12 10:59 ` Tejun Heo [this message]
2007-03-13 9:53 ` Soeren Sonnenburg
2007-03-12 11:22 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F53282.5040504@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@stusta.de \
--cc=jkarlson@cc.hut.fi \
--cc=kernel@nn7.de \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=mst@mellanox.co.il \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).