From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755083AbcJVSrd (ORCPT ); Sat, 22 Oct 2016 14:47:33 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:54196 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596AbcJVSrc (ORCPT ); Sat, 22 Oct 2016 14:47:32 -0400 Subject: Re: [PATCH v4 0/4] Add support for cros-ec-sensors To: Enric Balletbo i Serra , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org References: <1470045278-18161-1-git-send-email-enric.balletbo@collabora.com> Cc: Olof Johansson , Lee Jones , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Guenter Roeck , Gwendal Grignou From: Jonathan Cameron Message-ID: <45a6a20a-0ad4-99cd-28e5-cb75c083c215@kernel.org> Date: Sat, 22 Oct 2016 19:47:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1470045278-18161-1-git-send-email-enric.balletbo@collabora.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/08/16 10:54, Enric Balletbo i Serra wrote: > Hi, > > This is the four patchset to add support for the sensors behind the ChromeOS > Embedded Controller. > > This version has only the patches to support common functions and 3d > contiguous sensors like Accelerometers, Gyroscope and Magnetometer that are > presented by the ChromeOS EC Sensor hub. The patches were tested on an Oak board. > > The code was checked out from the ChromeOS v3.18 tree and forward ported to > mainline solving all the conflicts and build issues. I splitted the code in > single patches that have sense by themselves in order to avoid the chances > to fail. > > Note that the patches depends on this [1] to apply and work. > > [1] https://lkml.org/lkml/2016/7/1/188 OK. All looking good for this with one minor delay. I need to bring my tree up to date to apply it. I'll be doing a pull request to Greg (IIO patches are routed via his staging tree as we still have quite a few drivers in there and it's awfully convenient). Once that's pulled I can fast forward and apply this. Should get this done later this week if there are no hicups in my pull request. Jonathan > > Waiting for your reviews and feedback. > > Changes since v3 (requested by Guenter Roeck) > - Convert structure to a simple array > - Remove PM declarations > - Remove unnecessary initializations > - cros_ec_sensors_cmd_read_u16: Conversion should only be done if ret >= 0 > - Remove unnecessary else > - Add Reviewed-by tag for two last patches. > > Changes since v2 (requested by Guenter Roeck and Jonhatan Cameron) > - Rebased and fix build error. > - Include a list of possible values in the description of location attr. > - Fix some typos. > - Remove id sysfs entry. > - Skip filling by zero structure parameters that already zero'd. > - Order includes alphabetically. > - Propagate error codes. > > Changes since v1 (requested by Peter Meerwald-Stadler and Jonhatan Cameron) > - Check kernel-doc documentation and > - Bring some patches together. > - Fix some spelling mistakes. > - Include ABI documentation. > - Be more careful with buffer sizes (sprintf -> snprintf) > - Add cros_ec_sensors prefix to all function. > - Check return values on some functions. > > Best regards, > > Enric Balletbo i Serra (3): > iio: cros_ec_sensors_core: Add common functions for the ChromeOS EC > Sensor Hub. > iio: cros_ec_sensors: add ChromeOS EC Contiguous Sensors driver > platform/chrome: cros_ec_dev - Register cros-ec sensors > > Vincent Palatin (1): > platform/chrome: Introduce a new function to check EC features. > > Documentation/ABI/testing/sysfs-bus-iio-cros-ec | 18 + > drivers/iio/common/Kconfig | 1 + > drivers/iio/common/Makefile | 1 + > drivers/iio/common/cros_ec_sensors/Kconfig | 22 + > drivers/iio/common/cros_ec_sensors/Makefile | 6 + > .../iio/common/cros_ec_sensors/cros_ec_sensors.c | 322 +++++++++++++++ > .../common/cros_ec_sensors/cros_ec_sensors_core.c | 450 +++++++++++++++++++++ > .../common/cros_ec_sensors/cros_ec_sensors_core.h | 175 ++++++++ > drivers/platform/chrome/cros_ec_dev.c | 159 ++++++++ > include/linux/mfd/cros_ec.h | 10 + > include/linux/mfd/cros_ec_commands.h | 183 ++++++++- > 11 files changed, 1342 insertions(+), 5 deletions(-) > create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-cros-ec > create mode 100644 drivers/iio/common/cros_ec_sensors/Kconfig > create mode 100644 drivers/iio/common/cros_ec_sensors/Makefile > create mode 100644 drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c > create mode 100644 drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c > create mode 100644 drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.h >