From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Yassine Oudjana <yassine.oudjana@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Yassine Oudjana <y.oudjana@protonmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 3/3] soc: mediatek: scpsys: Add support for MT6735
Date: Mon, 27 Feb 2023 10:33:14 +0100 [thread overview]
Message-ID: <45a8757b-68b0-a79f-7ea3-426825493140@collabora.com> (raw)
In-Reply-To: <20230225101629.264206-4-y.oudjana@protonmail.com>
Il 25/02/23 11:16, Yassine Oudjana ha scritto:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
>
> Add support for SCPSYS power domains of MT6735. All non-CPU power domains
> are added except for MD2 (C2K modem), which is left out due to issues
> with powering it on.
>
This is a legacy driver and I'm convinced that we should do something to
actually *drop it forever*.
Please add support for power domains in mtk-pm-domains.c instead: if you need
a nice example about differences between the two, look at MT8173's implementation,
as that is present in both scpsys and mtk-pm-domains.
Summarizing, your MT6735 support will be about:
- Adding soc/mediatek/mt6735-pm-domains.h
- Adding support in mtk-pm-domains:
static const struct of_device_id scpsys_of_match[] = {
........
{
.compatible = "mediatek,mt6735-power-controller",
.data = &mt6735_scpsys_data,
},
.........
};
Cheers,
Angelo
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---
prev parent reply other threads:[~2023-02-27 9:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-25 10:16 [PATCH 0/3] MediaTek MT6735 SCPSYS support Yassine Oudjana
2023-02-25 10:16 ` [PATCH 1/3] dt-bindings: power: Add bindings for MediaTek MT6735 Yassine Oudjana
2023-02-27 8:14 ` Krzysztof Kozlowski
2023-02-25 10:16 ` [PATCH 2/3] dt-bindings: soc: mediatek: scpsys: Document MT6735 SCPSYS compatible string Yassine Oudjana
2023-02-27 8:15 ` Krzysztof Kozlowski
2023-02-27 9:33 ` AngeloGioacchino Del Regno
2023-02-25 10:16 ` [PATCH 3/3] soc: mediatek: scpsys: Add support for MT6735 Yassine Oudjana
2023-02-27 9:33 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45a8757b-68b0-a79f-7ea3-426825493140@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=y.oudjana@protonmail.com \
--cc=yassine.oudjana@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).