From: jerome Neanne <jneanne@baylibre.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, robh+dt@kernel.org, nm@ti.com,
kristo@kernel.org, khilman@baylibre.com, narmstrong@baylibre.com,
msp@baylibre.com, j-keerthy@ti.c, lee.jones@linaro.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 08/14] regulator: drivers: Add TI TPS65219 PMIC regulators support
Date: Fri, 22 Jul 2022 15:30:11 +0200 [thread overview]
Message-ID: <45c6843e-0447-cf5e-6f1a-3920032ac88c@baylibre.com> (raw)
In-Reply-To: <YtqabjVY1vRgjZlM@sirena.org.uk>
> @@ -0,0 +1,414 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * tps65219-regulator.c
> + *
Please make the entire comment a C++ one so things look more
intentional.
checkpatch is complaining about that:
---------------------------------------------------------------------
v5.19-rc6-PB-MSP1/0005-mfd-drivers-Add-TI-TPS65219-PMIC-support.patch
---------------------------------------------------------------------
WARNING: Improper SPDX comment style for 'drivers/mfd/tps65219.c',
please use '//' instead
#91: FILE: drivers/mfd/tps65219.c:1:
+/* SPDX-License-Identifier: GPL-2.0
Let me know if I should ignore checkpatch recommendations here.
next prev parent reply other threads:[~2022-07-22 13:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 9:17 [PATCH v1 00/14] Add support for TI TPS65219 PMIC Jerome Neanne
2022-07-19 9:17 ` [PATCH v1 01/14] MAINTAINERS: OMAP2+ support, add tps65218-pwrbutton Jerome Neanne
2022-07-19 9:17 ` [PATCH v1 02/14] regulator: dt-bindings: Add TI TPS65219 PMIC bindings Jerome Neanne
2022-07-19 12:55 ` Mark Brown
2022-07-19 9:17 ` [PATCH v1 03/14] regulator: dt-bindings: Add interrupts support to " Jerome Neanne
2022-07-19 12:58 ` Mark Brown
2022-07-20 23:37 ` Rob Herring
2022-07-19 9:17 ` [PATCH v1 04/14] regulator: dt-bindings: tps65219: Add power-button property Jerome Neanne
2022-07-20 23:39 ` Rob Herring
2022-07-21 7:09 ` Markus Schneider-Pargmann
2022-07-19 9:17 ` [PATCH v1 05/14] mfd: drivers: Add TI TPS65219 PMIC support Jerome Neanne
2022-07-19 9:17 ` [PATCH v1 06/14] mfd: drivers: Add interrupts support to TI TPS65219 PMIC Jerome Neanne
2022-07-19 9:17 ` [PATCH v1 07/14] mfd: tps65219: Add power-button support Jerome Neanne
2022-07-19 9:17 ` [PATCH v1 08/14] regulator: drivers: Add TI TPS65219 PMIC regulators support Jerome Neanne
2022-07-19 13:32 ` Mark Brown
2022-07-22 10:12 ` jerome Neanne
2022-07-22 12:39 ` Mark Brown
2022-07-22 13:30 ` jerome Neanne [this message]
2022-07-22 18:40 ` Mark Brown
2022-07-19 9:17 ` [PATCH v1 09/14] Input: Add tps65219 interrupt driven powerbutton Jerome Neanne
2022-07-19 9:17 ` [PATCH v1 10/14] arm64: defconfig: Add tps65219 as modules Jerome Neanne
2022-07-19 9:17 ` [PATCH v1 11/14] arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board Jerome Neanne
2022-07-19 13:00 ` Nishanth Menon
[not found] ` <CAOP-2kHgEhm+Ym8o7A49qP-oabO0i+89PGoWO0c9_2xz7oU89w@mail.gmail.com>
2022-07-19 13:17 ` Nishanth Menon
2022-07-19 9:17 ` [PATCH v1 12/14] arm64: dts: ti: Add pinmux and irq mapping for TPS65219 external interrupts Jerome Neanne
2022-07-19 9:17 ` [PATCH v1 13/14] arm64: dts: ti: k3-am642-sk: Enable tps65219 power-button Jerome Neanne
2022-07-19 9:17 ` [PATCH v1 14/14] arm64: defconfig: Add tps65219 power-button as module Jerome Neanne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45c6843e-0447-cf5e-6f1a-3920032ac88c@baylibre.com \
--to=jneanne@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.c \
--cc=khilman@baylibre.com \
--cc=kristo@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).