From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932296AbcFNW1T (ORCPT ); Tue, 14 Jun 2016 18:27:19 -0400 Received: from ausc60ps301.us.dell.com ([143.166.148.206]:50185 "EHLO ausc60ps301.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932182AbcFNW1P convert rfc822-to-8bit (ORCPT ); Tue, 14 Jun 2016 18:27:15 -0400 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:From:To:CC:Subject: Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language: X-MS-Has-Attach:X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader:x-originating-ip: Content-Type:Content-Transfer-Encoding:MIME-Version: Return-Path; b=Qd0UF1SYq/TtTVj9MaCdF43yOO863RINheiID256a2p1siysstMusO96 jxOfHNbHbSGmt8vA/kT2YLc9pOkr0+G5A6oA6HN666oe1TZRns7pbSG7H +xF7FWkYUV9wPWsL8I4m2eUlh10q9trZUNQMsaj2M+5E67YH5FLsbmBl+ E=; X-LoopCount0: from 10.175.216.250 X-IronPort-AV: E=Sophos;i="5.26,472,1459832400"; d="scan'208";a="834862723" From: To: , CC: , , , , , , Subject: RE: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD Thread-Topic: [PATCH v6] r8152: Add support for setting pass through MAC address on RTL8153-AD Thread-Index: AQHRwOmaCsYXCAkS0k2cIAYu9FvIC5/kHLcAgACkH4CAACJkAIAEoj4AgAADY4CAAAILAIAAHhuA///nkWA= Date: Tue, 14 Jun 2016 22:27:12 +0000 Message-ID: <45cd7254286844fbbd198afa68723063@ausx13mpc124.AMER.DELL.COM> References: <201606141828.10969@pali> <20160614164017.GB14477@kroah.com> <201606141847.36109@pali> <20160614.143521.2085426866285759820.davem@davemloft.net> In-Reply-To: <20160614.143521.2085426866285759820.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.208.89.195] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Tuesday, June 14, 2016 1:35 PM > To: pali.rohar@gmail.com > Cc: gregkh@linuxfoundation.org; andrew@lunn.ch; Limonciello, Mario > ; hayeswang@realtek.com; linux- > kernel@vger.kernel.org; netdev@vger.kernel.org; linux- > usb@vger.kernel.org; anthony.wong@canonical.com > Subject: Re: [PATCH v6] r8152: Add support for setting pass through MAC > address on RTL8153-AD > > From: Pali Rohár > Date: Tue, 14 Jun 2016 18:47:36 +0200 > > > You have never seen two ethernet cards with same MAC addresses? Right > I > > have not seen two USB, but there is non zero chance that could happen. > > It would be an error scenerio, and something to be avoided. > > It is a valid and correct assumption that one is able to put > several devices at the same time on the same physical network > and expect it to work. > > The behavior added by the change in question invalidates that. > > I'm trying to consider the long term aspects of this, which is that if > more devices adopt this scheme we're in trouble if we blindly > interpret the MAC address in this way. > Do you mean if other manufacturers start to ship devices with RTL8135-AD's w/ this pass through bit set and people start to try to mix and match? > This firmware MAC property facility seems to be designed with only an > extremely narrow use case being considered. Yes, as I understand it this is the reason that it's only on such specific devices that the mac address pass through bit is actually set on the efuse.