From: Nishant Malpani <nish.malpani25@gmail.com>
To: jic23@kernel.org
Cc: andriy.shevchenko@linux.intel.com, joe@perches.com,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
nish.malpani25@gmail.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 12/13] iio: light: st_uvis25_spi: Use vsprintf extension %pe for symbolic error name
Date: Sun, 22 Mar 2020 22:53:14 +0530 [thread overview]
Message-ID: <45d5a4bf468c490522d55f5c763061976804bf67.1584897364.git.nish.malpani25@gmail.com> (raw)
In-Reply-To: <cover.1584897364.git.nish.malpani25@gmail.com>
Utilize %pe format specifier from vsprintf while printing error logs
with dev_err(). Discards the use of unnecessary explicit casting and
prints symbolic error name which might prove to be convenient during
debugging.
Signed-off-by: Nishant Malpani <nish.malpani25@gmail.com>
---
Changes in v2:
- Rewrite commit subject line outlining the usage of %pe.
- Add a separator between regmap and its error name.
Based on conversations in [1] & [2].
[1] https://marc.info/?l=linux-iio&m=158427554607223&w=2
[2] https://marc.info/?l=linux-iio&m=158481647605891&w=2
---
drivers/iio/light/st_uvis25_spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/light/st_uvis25_spi.c b/drivers/iio/light/st_uvis25_spi.c
index a9ceae4f58b3..ae57e80a2e8f 100644
--- a/drivers/iio/light/st_uvis25_spi.c
+++ b/drivers/iio/light/st_uvis25_spi.c
@@ -31,8 +31,8 @@ static int st_uvis25_spi_probe(struct spi_device *spi)
regmap = devm_regmap_init_spi(spi, &st_uvis25_spi_regmap_config);
if (IS_ERR(regmap)) {
- dev_err(&spi->dev, "Failed to register spi regmap %d\n",
- (int)PTR_ERR(regmap));
+ dev_err(&spi->dev, "Failed to register spi regmap: %pe\n",
+ regmap);
return PTR_ERR(regmap);
}
--
2.20.1
next prev parent reply other threads:[~2020-03-22 17:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 17:23 [PATCH v2 00/13] Use vsprintf extension %pe for symbolic error Nishant Malpani
2020-03-22 17:23 ` [PATCH v2 01/13] iio: accel: kxsd9: Use vsprintf extension %pe for symbolic error name Nishant Malpani
2020-03-28 14:10 ` Jonathan Cameron
2020-03-22 17:23 ` [PATCH v2 02/13] iio: st_sensors_i2c: " Nishant Malpani
2020-03-28 14:11 ` Jonathan Cameron
2020-03-22 17:23 ` [PATCH v2 03/13] iio: st_sensors_spi: " Nishant Malpani
2020-03-28 14:12 ` Jonathan Cameron
2020-03-22 17:23 ` [PATCH v2 04/13] iio: gyro: bmg160_i2c: " Nishant Malpani
2020-03-28 14:13 ` Jonathan Cameron
2020-03-22 17:23 ` [PATCH v2 05/13] iio: gyro: bmg160_spi: " Nishant Malpani
2020-03-28 14:16 ` Jonathan Cameron
2020-03-22 17:23 ` [PATCH v2 06/13] iio: gyro: mpu3050: " Nishant Malpani
2020-03-28 14:18 ` Jonathan Cameron
2020-03-22 17:23 ` [PATCH v2 07/13] iio: imu: bmi160_i2c: " Nishant Malpani
2020-03-28 14:19 ` Jonathan Cameron
2020-03-22 17:23 ` [PATCH v2 08/13] iio: imu: bmi160_spi: " Nishant Malpani
2020-03-28 14:20 ` Jonathan Cameron
2020-03-22 17:23 ` [PATCH v2 09/13] iio: imu: inv_mpu6050_i2c: " Nishant Malpani
2020-03-28 14:21 ` Jonathan Cameron
2020-03-22 17:23 ` [PATCH v2 10/13] iio: imu: inv_mpu6050_spi: " Nishant Malpani
2020-03-28 14:22 ` Jonathan Cameron
2020-03-22 17:23 ` [PATCH v2 11/13] iio: light: st_uvis25_i2c: " Nishant Malpani
2020-03-28 14:25 ` Jonathan Cameron
2020-03-22 17:23 ` Nishant Malpani [this message]
2020-03-22 17:23 ` [PATCH v2 13/13] iio: magn: bmc150: " Nishant Malpani
2020-03-28 14:26 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45d5a4bf468c490522d55f5c763061976804bf67.1584897364.git.nish.malpani25@gmail.com \
--to=nish.malpani25@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=joe@perches.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).