linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	laurent.pinchart@ideasonboard.com
Cc: David Airlie <airlied@linux.ie>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips using the VSP1
Date: Thu, 29 Jun 2017 15:07:55 +0100	[thread overview]
Message-ID: <45eba5b6-d5a2-1007-1af5-2a076dd0630e@ideasonboard.com> (raw)
In-Reply-To: <1f52573cfb6e72b49af7a1071ffe136623fafc75.1498744799.git-series.kieran.bingham+renesas@ideasonboard.com>

> @@ -658,10 +660,14 @@ static irqreturn_t rcar_du_crtc_irq(int irq, void *arg)
>  	rcar_du_crtc_write(rcrtc, DSRCR, status & DSRCR_MASK);
>  
>  	if (status & DSSR_FRM) {
> -		drm_crtc_handle_vblank(&rcrtc->crtc);
> -
> -		if (rcdu->info->gen < 3)
> +		/*
> +		 * Gen 3 vblank and page flips are handled through the VSP
> +		 * completion handler
> +		 */
> +		if (rcdu->info->gen < 3) {

Of course as is obvious immediately after hitting send, this check was supposed
to be removed now that the interrupt is not registered.

Sorry for the noise and pre-released patch!

--
Kieran

  reply	other threads:[~2017-06-29 14:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.22236bc88adc598797b31ea82329ec99304fe34d.1498744799.git-series.kieran.bingham+renesas@ideasonboard.com>
2017-06-29 14:02 ` [PATCH v1 1/2] drm: rcar-du: Enable the FRM interrupt for vblank Kieran Bingham
2017-06-29 14:02 ` [PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips using the VSP1 Kieran Bingham
2017-06-29 14:07   ` Kieran Bingham [this message]
2017-06-29 15:58 ` [PATCH v1.1 " Kieran Bingham
2017-06-30  8:32   ` Kuninori Morimoto
2017-07-02 14:23     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45eba5b6-d5a2-1007-1af5-2a076dd0630e@ideasonboard.com \
    --to=kieran.bingham+renesas@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --subject='Re: [PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips using the VSP1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).