From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Qian Cai <cai@lca.pw>
Cc: linux-kernel@vger.kernel.org, Qian Cai <cai@lca.pw>,
paulus@samba.org, akpm@linux-foundation.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/cacheflush: fix variable set but not used
Date: Thu, 4 Jul 2019 00:27:03 +1000 (AEST) [thread overview]
Message-ID: <45f3Mr1jKVz9sBp@ozlabs.org> (raw)
In-Reply-To: <1559829493-28457-1-git-send-email-cai@lca.pw>
On Thu, 2019-06-06 at 13:58:13 UTC, Qian Cai wrote:
> The powerpc's flush_cache_vmap() is defined as a macro and never use
> both of its arguments, so it will generate a compilation warning,
>
> lib/ioremap.c: In function 'ioremap_page_range':
> lib/ioremap.c:203:16: warning: variable 'start' set but not used
> [-Wunused-but-set-variable]
>
> Fix it by making it an inline function.
>
> Signed-off-by: Qian Cai <cai@lca.pw>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/04db3ede40ae4fc23a5c4237254c4a53bbe4c1f2
cheers
prev parent reply other threads:[~2019-07-03 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 13:58 [PATCH] powerpc/cacheflush: fix variable set but not used Qian Cai
2019-06-27 19:54 ` Qian Cai
2019-07-03 14:27 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45f3Mr1jKVz9sBp@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).