From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9ACC433FF for ; Fri, 2 Aug 2019 02:28:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B92D206A3 for ; Fri, 2 Aug 2019 02:28:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730008AbfHBC20 (ORCPT ); Thu, 1 Aug 2019 22:28:26 -0400 Received: from ozlabs.org ([203.11.71.1]:42535 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728729AbfHBC2Y (ORCPT ); Thu, 1 Aug 2019 22:28:24 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 460B0k6y1Hz9sDB; Fri, 2 Aug 2019 12:28:22 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 7440ea8b2a4430eef5120d0a7faac6c39304ae6d In-Reply-To: <20190730143704.060a2606@canb.auug.org.au> To: Stephen Rothwell , Benjamin Herrenschmidt From: Michael Ellerman Cc: Linux kernel Mailing List , PowerPC , Kees Cook , "Gustavo A. R. Silva" Subject: Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through Message-Id: <460B0k6y1Hz9sDB@ozlabs.org> Date: Fri, 2 Aug 2019 12:28:22 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-07-30 at 04:37:04 UTC, Stephen Rothwell wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warning (Building: powerpc): > > drivers/macintosh/smu.c: In function 'smu_queue_i2c': > drivers/macintosh/smu.c:854:21: warning: this statement may fall through [-= > Wimplicit-fallthrough=3D] > cmd->info.devaddr &=3D 0xfe; > ~~~~~~~~~~~~~~~~~~^~~~~~~ > drivers/macintosh/smu.c:855:2: note: here > case SMU_I2C_TRANSFER_STDSUB: > ^~~~ > > Cc: Benjamin Herrenschmidt > Cc: Gustavo A. R. Silva > Cc: Kees Cook > Signed-off-by: Stephen Rothwell Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/7440ea8b2a4430eef5120d0a7faac6c39304ae6d cheers