From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78950C4167B for ; Fri, 8 Dec 2023 17:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233803AbjLHR4k (ORCPT ); Fri, 8 Dec 2023 12:56:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235946AbjLHR4f (ORCPT ); Fri, 8 Dec 2023 12:56:35 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF527198D for ; Fri, 8 Dec 2023 09:56:40 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A69DC433C8; Fri, 8 Dec 2023 17:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702058200; bh=9xxAbGXzLKVinje/1qrTMCGO6En/seWuAJ9zKs2OvRo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KktLrsaHMqHuSdviPwgKD8eaGdxnuIIA4B6K6LyNeKKK7EhZ2jsE5y2g0PbAlQLer 5AZD+X8hVBf/pb6iCzYpjpO1mYT0e5phnU3CUE6Ye44qGWVDkbiSW1wIJ01RKfpqH1 aIsWiOCHUl+yjhU69kpDY6WMx48AuAE3yhIXC1chevQQLoEBFmjqiEysAoA2jweMb9 EmhyG8e1p62psBESzHBntY1HPYMm/o6U/cZsY2Jw/gG5H1OkQdrGgZc5bezgme0n3P vdBkZN5APkNeAlIxu6r+1QD1FytYmVy1OGPCUGxcdSSgAwFdHKWNbrN/KOExS72/Km KOcx35phxF+6w== Message-ID: <462da4bf-34f8-40c4-8772-9850b3127baf@kernel.org> Date: Fri, 8 Dec 2023 10:56:39 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next v1 07/16] netdev: netdevice devmem allocator Content-Language: en-US To: Mina Almasry , Shailend Chand , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Jeroen de Borst , Praveen Kaligineedi , Jesper Dangaard Brouer , Ilias Apalodimas , Arnd Bergmann , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Yunsheng Lin , Harshitha Ramamurthy , Shakeel Butt , Willem de Bruijn , Kaiyuan Zhang References: <20231208005250.2910004-1-almasrymina@google.com> <20231208005250.2910004-8-almasrymina@google.com> From: David Ahern In-Reply-To: <20231208005250.2910004-8-almasrymina@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/7/23 5:52 PM, Mina Almasry wrote: > diff --git a/net/core/dev.c b/net/core/dev.c > index b8c8be5a912e..30667e4c3b95 100644 > --- a/net/core/dev.c > +++ b/net/core/dev.c > @@ -2120,6 +2120,41 @@ static int netdev_restart_rx_queue(struct net_device *dev, int rxq_idx) > return err; > } > > +struct page_pool_iov *netdev_alloc_dmabuf(struct netdev_dmabuf_binding *binding) > +{ > + struct dmabuf_genpool_chunk_owner *owner; > + struct page_pool_iov *ppiov; > + unsigned long dma_addr; > + ssize_t offset; > + ssize_t index; > + > + dma_addr = gen_pool_alloc_owner(binding->chunk_pool, PAGE_SIZE, Any reason not to allow allocation sizes other than PAGE_SIZE? e.g., 2048 for smaller MTUs or 8192 for larger ones. It can be a property of page_pool and constant across allocations vs allowing different size for each allocation.