From: Phil Reid <preid@electromag.com.au>
To: Song Qiang <songqiang1304521@gmail.com>,
jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer
Date: Fri, 21 Sep 2018 10:05:38 +0800 [thread overview]
Message-ID: <4633d30b-b493-d70b-dd7b-3f5bc3e16e78@electromag.com.au> (raw)
In-Reply-To: <20180920131340.6699-1-songqiang1304521@gmail.com>
On 20/09/2018 9:13 PM, Song Qiang wrote:
> PNI RM3100 magnetometer is a high resolution, large signal immunity
> magnetometer, composed of 3 single sensors and a processing chip.
> PNI is currently not in the vendors list, so this is also adding it.
>
In the subject: Isn't the RM3100 a 3axis mag.
The 9axis bit comes when you combine it with an accel / gryo I think.
... snip
> +++ b/Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt
> @@ -0,0 +1,57 @@
> +* PNI RM3100 9-axis magnetometer sensor
> +
> +I2C Bus:
> +
> +Required properties:
> +
> +- compatible : should be "pni,rm3100-i2c"
> +- reg : the I2C address of the magnetometer
> +
... snip
> +SPI Bus:
> +
> +Required properties:
> +
> +- compatible : should be "pni,rm3100-spi"
> +- reg : address of sensor, usually 0 or 1.
> +
Looking at other drivers supporting i2c / spi.
They use the same compatible for both.
eg: see iio/accel/adxl345_*.c
and it's binding doc:
Required properties:
- compatible : should be "adi,adxl345"
- reg : the I2C address or SPI chip select number of the sensor
next prev parent reply other threads:[~2018-09-21 2:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 13:13 [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer Song Qiang
2018-09-20 13:46 ` Peter Meerwald-Stadler
2018-09-20 18:05 ` Song Qiang
2018-09-22 9:42 ` Jonathan Cameron
2018-09-22 10:08 ` Jonathan Cameron
2018-09-21 5:07 ` Phil Reid
2018-09-21 11:29 ` Song Qiang
2018-09-21 12:20 ` Jonathan Cameron
2018-09-22 9:18 ` Song Qiang
2018-09-21 2:05 ` Phil Reid [this message]
2018-09-21 9:13 ` Song Qiang
2018-09-22 10:14 ` Jonathan Cameron
2018-09-23 15:17 ` Song Qiang
2018-09-24 20:04 ` Jonathan Cameron
2018-09-24 14:37 ` Song Qiang
2018-09-29 12:44 ` Jonathan Cameron
2018-09-23 11:01 ` Dan Carpenter
[not found] ` <5baa1b01.1c69fb81.f0d8f.30c6@mx.google.com>
2018-09-26 0:34 ` Song Qiang
2018-09-29 11:22 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4633d30b-b493-d70b-dd7b-3f5bc3e16e78@electromag.com.au \
--to=preid@electromag.com.au \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=songqiang1304521@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).