From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751778AbdGRKSi (ORCPT ); Tue, 18 Jul 2017 06:18:38 -0400 Received: from galahad.ideasonboard.com ([185.26.127.97]:56603 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751724AbdGRKSg (ORCPT ); Tue, 18 Jul 2017 06:18:36 -0400 From: Laurent Pinchart To: Rob Herring Cc: Maxime Ripard , Mark Brown , Thierry Reding , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Mark Rutland , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Boris Brezillon , Thomas Petazzoni Subject: Re: [PATCH 11/18] dt-bindings: display: Add Allwinner MIPI-DSI bindings Date: Tue, 18 Jul 2017 13:18:42 +0300 Message-ID: <4634787.BNPAe4WyE2@avalon> User-Agent: KMail/4.14.10 (Linux/4.9.34-gentoo; KDE/4.14.32; x86_64; ; ) In-Reply-To: <20170717184149.sv4xdspjwnhmctog@rob-hp-laptop> References: <41dca303c02faf350e765b81c36ddcddbba6f950.1499955058.git-series.maxime.ripard@free-electrons.com> <20170717184149.sv4xdspjwnhmctog@rob-hp-laptop> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 17 Jul 2017 13:41:49 Rob Herring wrote: > On Thu, Jul 13, 2017 at 04:13:06PM +0200, Maxime Ripard wrote: > > The Allwinner SoCs usually come with a DSI encoder. Add a binding for it. > > > > Signed-off-by: Maxime Ripard > > --- > > > > Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 85 > > +++++++- > > 1 file changed, 85 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt> > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt new file > > mode 100644 > > index 000000000000..2e7c5aa7020f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > @@ -0,0 +1,85 @@ > > +Allwinner A31 DSI Encoder > > +========================= > > + > > +The DSI pipeline consists of two separate blocks: the DSI controller > > +itself, and its associated D-PHY. > > + > > +DSI Encoder > > +----------- > > + > > +The DSI Encoder generates the DSI signal from the TCON's. > > + > > +Required properties: > > + - compatible: value must be one of: > > + * allwinner,sun6i-a31-mipi-dsi > > + - reg: base address and size of memory-mapped region > > + - interrupts: interrupt associated to this IP > > + - clocks: phandles to the clocks feeding the DSI encoder > > + * bus: the DSI interface clock > > + * mod: the DSI module clock > > + - clock-names: the clock names mentioned above > > + - phys: phandle to the D-PHY > > + - phy-names: must be "dphy" > > + - resets: phandle to the reset controller driving the encoder > > + > > + - ports: A ports node with endpoint definitions as defined in > > + Documentation/devicetree/bindings/media/video-interfaces.txt. The > > + port should be the input endpoint, usually coming from the > > + associated TCON. > > Output port for bridge/panel? > > > + > > +D-PHY > > +----- > > + > > +Required properties: > > + - compatible: value must be one of: > > + * allwinner,sun6i-a31-mipi-dphy > > + - reg: base address and size of memory-mapped region > > + - clocks: phandles to the clocks feeding the DSI encoder > > + * bus: the DSI interface clock > > + * mod: the DSI module clock > > + - clock-names: the clock names mentioned above > > + - resets: phandle to the reset controller driving the encoder > > + > > +Example: > > + > > +dsi0: dsi@01ca0000 { > > Drop the leading 0. > > > + compatible = "allwinner,sun6i-a31-mipi-dsi"; > > + reg = <0x01ca0000 0x1000>; > > + interrupts = ; > > + clocks = <&ccu CLK_BUS_MIPI_DSI>, > > + <&ccu CLK_DSI_SCLK>; > > + clock-names = "bus", "mod"; > > + resets = <&ccu RST_BUS_MIPI_DSI>; > > + phys = <&dphy0>; > > + phy-names = "dphy"; > > > > + #address-cells = <1>; > > + #size-cells = <0>; > > Not needed. > > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + dsi0_in: port@0 { I don't think the label for the port is needed, you should only reference the endpoint. > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0>; > > + > > + dsi0_in_tcon0: endpoint@0 { > > + reg = <0>; > > Don't need reg when there's only 1 endpoint. And no reg for the port name either when there's a single port. This can all be simplified to dsi0: dsi@1ca0000 { compatible = "allwinner,sun6i-a31-mipi-dsi"; reg = <0x01ca0000 0x1000>; interrupts = ; clocks = <&ccu CLK_BUS_MIPI_DSI>, <&ccu CLK_DSI_SCLK>; clock-names = "bus", "mod"; resets = <&ccu RST_BUS_MIPI_DSI>; phys = <&dphy0>; phy-names = "dphy"; port { dsi0_in_tcon0: endpoint { remote-endpoint = <&tcon0_out_dsi0>; }; }; }; > > + remote-endpoint = <&tcon0_out_dsi0>; > > + }; > > + }; > > + }; > > +}; [snip] -- Regards, Laurent Pinchart