From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E22DC74A4B for ; Fri, 10 Mar 2023 13:25:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229844AbjCJNZj (ORCPT ); Fri, 10 Mar 2023 08:25:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229804AbjCJNZh (ORCPT ); Fri, 10 Mar 2023 08:25:37 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DF465A181; Fri, 10 Mar 2023 05:25:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C389961743; Fri, 10 Mar 2023 13:23:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAD5DC433D2; Fri, 10 Mar 2023 13:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678454621; bh=JxGawBRBiAOKWI5mLLvbiOwWip4wIDn5bcx4U5k5Nkw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nJ80UnqY7geRXzONADjCSgCs2PTfGcUUR3qPrctyesUDIck0YSBHRNbYu1ajilYq7 lZvbNJ+YUFxK5yqdzVksIHiQT6U/XIKt0wpnp29IV2wNpIdSE4Ug6rl9emMFjCWACa 2RTCzQU4znfxqahoGfB4ruot4XQzewlrqsrVvK3GYsGOM972CvQDp1m+kKxv74S9UY 1FAVhLtvkJ65oGHRW/4MyrS4nm/lRVcoUIW6iTlaZyEJNFui1LFeAWuu9E6l8gPJQg V6ykPimE4c4oVP0mBRZ9fFstknXkh9oi4JBfwfY3GJkSRy6wS2ImQsux+NnFImGhog ML4HFt+sPST4Q== Message-ID: <46415d8e-3c92-d489-3f44-01a586160082@kernel.org> Date: Fri, 10 Mar 2023 15:23:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v3 3/6] soc: ti: pruss: Add pruss_cfg_read()/update() API To: Md Danish Anwar , MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Vignesh Raghavendra , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon Cc: linux-remoteproc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, srk@ti.com, devicetree@vger.kernel.org, netdev@vger.kernel.org References: <20230306110934.2736465-1-danishanwar@ti.com> <20230306110934.2736465-4-danishanwar@ti.com> <7076208d-7dca-6980-5399-498e55648740@kernel.org> <367f6b50-e4cc-c3eb-e8e9-dabd4e044530@ti.com> Content-Language: en-US From: Roger Quadros In-Reply-To: <367f6b50-e4cc-c3eb-e8e9-dabd4e044530@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Danish, On 10/03/2023 13:53, Md Danish Anwar wrote: > Hi Roger, > > On 09/03/23 17:00, Md Danish Anwar wrote: >> Hi Roger, >> >> On 08/03/23 17:12, Roger Quadros wrote: >>> >>> >>> On 08/03/2023 13:36, Md Danish Anwar wrote: >>>> Hi Roger, >>>> >>>> On 08/03/23 13:57, Roger Quadros wrote: >>>>> Hi, >>>>> >>>>> On 06/03/2023 13:09, MD Danish Anwar wrote: >>>>>> From: Suman Anna >>>>>> >>>>>> Add two new generic API pruss_cfg_read() and pruss_cfg_update() to >>>>>> the PRUSS platform driver to allow other drivers to read and program >>>>>> respectively a register within the PRUSS CFG sub-module represented >>>>>> by a syscon driver. This interface provides a simple way for client >>>>> >>>>> Do you really need these 2 functions to be public? >>>>> I see that later patches (4-6) add APIs for doing specific things >>>>> and that should be sufficient than exposing entire CFG space via >>>>> pruss_cfg_read/update(). >>>>> >>>>> >>>> >>>> I think the intention here is to keep this APIs pruss_cfg_read() and >>>> pruss_cfg_update() public so that other drivers can read / modify PRUSS config >>>> when needed. >>> >>> Where are these other drivers? If they don't exist then let's not make provision >>> for it now. >>> We can provide necessary API helpers when needed instead of letting client drivers >>> do what they want as they can be misused and hard to debug. >>> >> >> The ICSSG Ethernet driver uses pruss_cfg_update() API. It is posted upstream in >> the series [1]. The ethernet driver series is dependent on this series. In >> series [1] we are using pruss_cfg_update() in icssg_config.c file, >> icssg_config() API. You can instead add a new API on what exactly you want it to do rather than exposing entire CFG space. >> >> So for this, the API pruss_cfg_update() needs to be public. >> >> [1] https://lore.kernel.org/all/20230210114957.2667963-3-danishanwar@ti.com/ >> > > I will keep this patch as it is as pruss_cfg_update() needs to be public for > ICSSG Ethernet driver and pruss_cfg_read() is kind of a complementary function > to update. I will do required changes in other patches and send next revision > if that's OK with you. Please let me know. > >>>> >>>> The later patches (4-6) add APIs to do specific thing, but those APIs also >>>> eventually call pruss_cfg_read/update(). >>> >>> They can still call them but they need to be private to pruss.c >>> >>>> >>>>>> drivers without having them to include and parse the CFG syscon node >>>>>> within their respective device nodes. Various useful registers and >>>>>> macros for certain register bit-fields and their values have also >>>>>> been added. >>>>>> >>>>>> It is the responsibility of the client drivers to reconfigure or >>>>>> reset a particular register upon any failures. >>>>>> >>>>>> Signed-off-by: Suman Anna >>>>>> Co-developed-by: Grzegorz Jaszczyk >>>>>> Signed-off-by: Grzegorz Jaszczyk >>>>>> Signed-off-by: Puranjay Mohan >>>>>> --- >>>>>> drivers/soc/ti/pruss.c | 41 +++++++++++++ >>>>>> include/linux/remoteproc/pruss.h | 102 +++++++++++++++++++++++++++++++ >>>>>> 2 files changed, 143 insertions(+) >>>>>> >>>>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c >>>>>> index c8053c0d735f..537a3910ffd8 100644 >>>>>> --- a/drivers/soc/ti/pruss.c >>>>>> +++ b/drivers/soc/ti/pruss.c >>>>>> @@ -164,6 +164,47 @@ int pruss_release_mem_region(struct pruss *pruss, >>>>>> } >>>>>> EXPORT_SYMBOL_GPL(pruss_release_mem_region); >>>>> cheers, -roger